[HOLD for payment 2021-12-15] [$250] Attachment - If file name is too long, attachment preview is overflowing the modal - Reported by: @Santhosh-Sellavel

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Attach this file to a conversation looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongname.zip
2. Check the attachment preview

Expected Result:

Attachment name should not overflow the modal.

Actual Result:

Attachment name is overflowing the modal

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.12-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: (In this case GH conversation) #5755 (comment)

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Christinadobrzyn]

It looks like this bug was reported in this GH where a similar issue is being fixed.

I suggest we hold off on getting proposals for this until we see if this PR fixes the issue. What do you think @Luke9389?

[Santhosh-Sellavel]

First of all this issue was not addressed in the PR #5969

Also, we would still need to hold proposals.
Because as @chiragsalian said here

we might want to pull in design opinion for it and to decide if its ROI is worth it.

Then, based on the outcome of the discussion we should resume proposals!

[Luke9389]

Thanks, @Christinadobrzyn, good catch. Now that I read the PR comments on that, Chirag did recommend making a separate issue for this. I'll tag @Expensify/design to see how we want to chop this text. I think a ... in the middle of the text could be cool so we can still see the file extension at the end.

[Christinadobrzyn]

Sorry, @Santhosh-Sellavel I should have asked you if this fix was in the PR - thanks for clarifying.

Sounds like we'll wait to get thoughts from design on what the truncated attachment name should look like and then collect proposals.

[Christinadobrzyn]

@Expensify/design when possible, can you let us know how you'd like the truncated attachment name should look in newdot?