[Due for payment 2025-06-27] [$250] Workspace - In offline, in preview red dot not displayed and category no longer valid not shown

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Slottwo1 sivappa3@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open a workspace chat
3. Create a manual expense with advertisement category
4. Go to category page
5. Turn off internet
6. Tap advertisement and delete the category
7. Go back to workspace chat
8. Turn on internet

Expected Result:

In offline, in preview red dot must be displayed and category no longer valid message must be shown.

Actual Result:

In offline, in preview red dot not displayed and category no longer valid not shown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021920547540652397343
• Upwork Job ID: 1920547540652397343
• Last Price Increase: 2025-05-08
• Automatic offers:
• Tony-MK | Contributor | 107310090

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Tony-MK]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-14 15:21:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - In offline, in preview red dot is not displayed, andthe category is no longer valid not shown

What is the root cause of that problem?

The deleteWorkspaceCategories function does not optimistically push the new categoryOutOfPolicy transaction violation to optimisticData.

App/src/libs/actions/Policy/Category.ts

Lines 969 to 980 in 74b93b9

	function deleteWorkspaceCategories(policyID: string, categoryNamesToDelete: string[]) {
	const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`];
	const policyCategories = allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`] ?? {};
	const optimisticPolicyCategoriesData = categoryNamesToDelete.reduce<Record<string, Partial<PolicyCategory>>>((acc, categoryName) => {
	acc[categoryName] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, enabled: false};
	return acc;
	}, {});
	const shouldDisableRequiresCategory = !hasEnabledOptions(
	Object.values(policyCategories).filter((category) => !categoryNamesToDelete.includes(category.name) && category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE),
	);
	const onyxData: OnyxData = {
	optimisticData: [

What changes do you think we should make in order to solve the problem?

Let's create a function, eg, getTransactionsViolationsOnyxData, that can use ViolationsUtils.getViolationsOnyxData to get the OnyxData of each transaction, if the policy or its categories or tag lists are updated or optimistic.

function getTransactionsViolationsOnyxData(
    policyID: string,
    optimisticPolicy: OnyxEntry<Policy> | undefined, 
    optimisticPolicyTagLists: OnyxEntry<PolicyTagLists> | undefined,
    optimisticPolicyCategories:  OnyxEntry<PolicyCategories> | undefined, 
): OnyxData {
    const onyxData: { optimisticData: OnyxUpdate[]; failureData: OnyxUpdate[] } = {optimisticData: [], failureData: []};
    const policy = optimisticPolicy ?? allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`];
   
    if (
        isEmptyObject(policy) ||
        (isEmptyObject(optimisticPolicy) && isEmptyObject(optimisticPolicyTagLists) && isEmptyObject(optimisticPolicyCategories))
     ) {
         return onyxData;
     }

    const policyTagLists =  optimisticPolicyTagLists ?? allPolicyTagLists?.[`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`] ?? {};
    const policyCategories = optimisticPolicyCategories ?? allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`] ?? {};
    const hasDependentTags = hasDependentTagsUtils(policy, policyTagLists);

   getAllPolicyReports(policyID).forEach((report) => {
        if (!report?.reportID){
            return;
        }

        const isInvoiceReport = isInvoiceReportUtils(report)

        getReportTransactions(report.reportID).forEach((transaction: Transaction) => {
            const transactionViolations = allTransactionViolations?.[transaction.transactionID] ?? [];
            const transactionViolationsOnyxData = ViolationsUtils.getViolationsOnyxData(
                transaction,
                transactionViolations, 
                policy,
                policyTagLists, 
                policyCategories, 
                hasDependentTags, 
                isInvoiceReport,
            );
        
            if (transactionViolationsOnyxData){
                onyxData.optimisticData.push(transactionViolationsOnyxData);
                onyxData.failureData.push({
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`,
                    value: transactionViolations,
                });
            }
        });
    });
    return onyxData;
}

Use getTransactionsViolationsOnyxData in the functions that need the policy's updated transaction violations, such as deleteWorkspaceCategories.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create tests for deleteWorkspaceCategories to check whether the categoryOutOfPolicy violation is in optimisticData and other functions that require updating the policy's transaction violation onyx.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021920547540652397343

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)