[Due for payment 2025-05-27] [$250] mWeb - Workspace - Tapping additional approval page shows admin briefly.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9 1.38-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6022808
Email or phone of affected tester (no customers): Slottwo1 y@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings - members
3. Invite a member
4. Tap workflows - add approval
5. Tap additional approval
6. Upgrade and complete the flow
7. Tap additional approval again
8. Refresh the page

Expected Result:

Tapping additional approval page musnt show admin briefly.

Actual Result:

Tapping additional approval page shows admin briefly.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021918279588313523186
• Upwork Job ID: 1918279588313523186
• Last Price Increase: 2025-05-02

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping additional approval page shows admin briefly.

What is the root cause of that problem?

When first loading the page, the approvalWorkflow Onyx data might not be available yet:

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 57 in 3c475ba

const [approvalWorkflow] = useOnyx(ONYXKEYS.APPROVAL_WORKFLOW);

What changes do you think we should make in order to solve the problem?

Check if that data is still loading using isLoadingOnyxValue util and display FullScreenLoadingIndicator if so.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[ishakakkad]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-30 07:24:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Tapping additional approval page shows admin briefly.

What is the root cause of that problem?

We show the list of users based on following condition

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 101 in 4453806

const isEmailAlreadyInApprovers = approversFromWorkflow?.some((approver, index) => approver?.email === email && index !== approverIndex);

We fetch the approvalWorkflow from here and during refresh approvalWorkflow not present and available after some time

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 57 in 4453806

const [approvalWorkflow] = useOnyx(ONYXKEYS.APPROVAL_WORKFLOW);

What changes do you think we should make in order to solve the problem?

To fix this we need to add following logic

const [approvalWorkflow, metadata] = useOnyx(ONYXKEYS.APPROVAL_WORKFLOW);
const isLoading = metadata.status === 'loading';

if(isLoading) {
return null; // OR show loading state
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Na

What alternative solutions did you explore? (Optional)

const [approvalWorkflow, metadata] = useOnyx(ONYXKEYS.APPROVAL_WORKFLOW);
const isLoading = isLoadingOnyxValue(metadata);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ishakakkad]

Coming from here, same RCA but different page #60786 (comment)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The approver list shows the admin briefly.

What is the root cause of that problem?

When intiializing the list, we exclude already added user from the list.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 100 to 104 in 4453806

	// Do not allow the same email to be added twice
	const isEmailAlreadyInApprovers = approversFromWorkflow?.some((approver, index) => approver?.email === email && index !== approverIndex);
	if (isEmailAlreadyInApprovers && selectedApproverEmail !== email) {
	return null;
	}

However, approvalWorkflow onyx data is still loading, so the admin member is added to the list briefly.

What changes do you think we should make in order to solve the problem?

Return an empty sections when the workflow is still loading.

const [approvalWorkflow, approvalWorkflowMetadata] = useOnyx(ONYXKEYS.APPROVAL_WORKFLOW);
const isApprovalWorkflowLoading = isLoadingOnyxValue(approvalWorkflowMetadata);

const sections: ApproverSection[] = useMemo(() => {
    const approvers: SelectionListApprover[] = [];
    console.log('employee list', employeeList, approvalWorkflow)
    if (isApprovalWorkflowLoading) {
        return [];
    }

Then, update shouldShowListEmptyContent so it doesn't show when it's still loading.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Line 163 in 4453806

const shouldShowListEmptyContent = !debouncedSearchTerm && approvalWorkflow && !sections.at(0)?.data.length;

If we want to show loader, pass showLoadingPlaceholder to the list.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 275 to 276 in 4453806

	<SelectionList
	sections={sections}

showLoadingPlaceholder={isApprovalWorkflowLoading}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[zanyrenney]

Bunch of proposals 🎉

[zanyrenney]

great find of the related issue @ishakakkad thank you!