[Collect pricing update] User lands on a Not Found page when clicking "Add members" if there's no default workspace set

[amyevans]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.31-2
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: @jayeshmangwani
Slack conversation (hyperlinked to channel name): #expensify-bugs

Action Performed:

1. Log in with a new user and complete the onboarding flow.
2. Select the "Manage my team's expenses" option.
3. Navigate to Settings -> Workspaces and create a new workspace.
4. Delete the Default workspace.
5. Go to Subscription and click "Add members" under the Your plan section.

Expected Result:

"Add members" button shouldn't be visible if there's no default workspace

Actual Result:

We land on a Not Found page when clicking "Add members" if there's no default workspace set

Workaround:

N/A

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Untitled.mov

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

Well, well.. what are the chances!

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-23 16:24:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Currently here

App/src/pages/settings/Subscription/SubscriptionPlan/AddMembersButton/index.tsx

Line 23 in a2b6087

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(activePolicyID))}

we navigate directly to activePolicyID but when user delete the policy activePolicyID remain same although its no more available

What changes do you think we should make in order to solve the problem?

we can disable the button if we don't have workspaceAccountID (As soon we delete the policy workspaceAccountID become undefined)

const activePolicy = getPolicy(activePolicyID);

<Button
    text={translate('subscription.yourPlan.addMembers')}
    style={shouldUseNarrowLayout ? styles.ph5 : styles.ph8}
    icon={Expensicons.UserPlus}
    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(activePolicyID))}
    isDisabled={!activePolicy?.workspaceAccountID}
/>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

We should add a model here to let user know there is no default policy available right now please choose one
and redirect them to policy list to choose default policy

const activePolicy = getPolicy(activePolicyID);
const [isSetDefaultWorkspaceModalOpen, setIsSetDefaultWorkspaceModalOpen] = useState(false);

<>
<Button
        text={translate('subscription.yourPlan.addMembers')}
...

    <ConfirmModal
        title={translate('workspace.common.defaultWorkspace')}
        isVisible={isSetDefaultWorkspaceModalOpen}
        onConfirm={() => {
            Navigation.navigate(ROUTES.SETTINGS_WORKSPACES.route);
            setIsSetDefaultWorkspaceModalOpen(false);
        }}
        onCancel={() => setIsSetDefaultWorkspaceModalOpen(false)}
        prompt={translate('subscription.yourPlan.defaultWorkspacePrompt')}
        confirmText={translate('subscription.yourPlan.setDefaultWorkspace')}
        cancelText={translate('common.cancel')}
        danger
    />
</>

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue. (as per slack discussion)