[DUE FOR PAYMENT 5/20] [$250] Login - Not able to log in with a new account while navigating to public room as anon user

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5967397&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.3.2/Safari, iPhone 13 18.3.2/Safari
App Component: Other

Action Performed:

1.Log out of New Expensify
2.Navigate to this link - https://staging.new.expensify.com/r/2091104345528462
3.Verify you can see the room as an anonymous user
4.Click on Sign In or any other action that should not be allowed to an unauthenticated user
5.Verify you're redirected to the Sign In page
6.Log in with a new account

Expected Result:

The onboarding flow appears after sign in

Actual Result:

Not able to log in with a new account while navigating to public room as anonymous user. After entering a new email, the MC input is displayed, but the MC doesn't arrive to the inbox. After requesting a new MC, there is an error message "There was an error. Please try again. If the issue persists, please reach out to concierge@expensify.com".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915132779694893213
• Upwork Job ID: 1915132779694893213
• Last Price Increase: 2025-04-23

Issue Owner

Current Issue Owner: @JS00001

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kpadmanabhan]

@jponikarchuk : unable to reproduce the issue. Email with MC comes fine for me on staging. Are you still able to reproduce this issue? Could it be that staging was fixed in the meantime?

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-21 09:14:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login with new account as anonymous user shows MC view instead of sign up view.

What is the root cause of that problem?

Sign up view is shown based on this condition.

App/src/pages/signin/SignInPage.tsx

Line 114 in 7a42c6a

const shouldShouldSignUpWelcomeForm = !!credentials?.login && !isAccountValidated && !account?.accountExists && !account?.domainControlled;

Everything is true except !isAccountValidated. isAccountValidated in this case is true, so it becomes false. The account validated state comes from this temp hook.

App/src/hooks/useAccountValidation.tsx

Lines 4 to 12 in 7a42c6a

	// TODO: Remove/Update this hook once we remove the user data and migrate to account data in https://github.com/Expensify/App/issues/59277
	function useAccountValidation() {
	// Some places are using the current value to compare, so we shouldn't cast to boolean
	const [isAccountValidated] = useOnyx(ONYXKEYS.ACCOUNT, {selector: (account) => account?.validated});
	const [isUserValidated] = useOnyx(ONYXKEYS.USER, {selector: (user) => user?.validated});
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	return isAccountValidated || isUserValidated;
	}

It checks both user and account validated. In anonymous user case, user.validated is true, so the hook also returns true.

What changes do you think we should make in order to solve the problem?

Instead of using ||, we should use ??, so we will check account.validated first and only fallback if it's undefined.

OR

Don't use the hook and use account.validated directly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can render SignInPage, merge the onyx necessary data to show the sign up view and verify it exists.

[jponikarchuk]

@kpadmanabhan Tester can still reproduce this issue. We can receive a MC when try to log in with an existing user. But when we enter a new email, the MC input appears instead of an onboarding flow.

Recording.961.mp4

[CortneyOfstad]

Getting eyes on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915132779694893213