[Due for payment 2025-05-06][$250] Update the "Prohibited Expenses" tab in "Rules" to show as blank when no prohibited expenses are enabled

[MitchExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: web
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): mitch@expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/469530
Issue reported by: mitch@expensify.com
Slack conversation (hyperlinked to channel name): NA (https://github.com/Expensify/Expensify/issues/469530#issuecomment-2786453506)

Action Performed:

1. Create a Workspace in New Expensify
2. Enable "rules" via "more features"
3. Go to the Rules tab of the workspace

Expected Result:

The empty state of the "Prohibited expenses" row should be unfilled and use our standard styles

Actual Result:

The empty state of the "Prohibited expenses" row shows "None"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912298665900341481
• Upwork Job ID: 1912298665900341481
• Last Price Increase: 2025-04-16

Issue Owner

Current Issue Owner: @tylerkaraszewski

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MitchExpensify]

This is on the receiptLineItems beta which is enabled on expensifail.com if you wish to reproduce @lschurr

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the "Prohibited Expenses" tab in "Rules" to show as blank when no prohibited expenses are enabled

What is the root cause of that problem?

This code block returns 'none' when no prohibited expenses are enabled.

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 141 to 144 in d30f77c

	// If no expenses are prohibited, return empty string
	if (!prohibitedExpensesList.length) {
	return translate('workspace.rules.individualExpenseRules.none');
	}

What changes do you think we should make in order to solve the problem?

Remove this code block

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 141 to 144 in d30f77c

	// If no expenses are prohibited, return empty string
	if (!prohibitedExpensesList.length) {
	return translate('workspace.rules.individualExpenseRules.none');
	}

And perform some cleanup.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Prohibited Expenses" tab in the Rules section currently shows "None" when no prohibited expenses are enabled.

What is the root cause of that problem?

We return the translation for "None" (translate('workspace.rules.individualExpenseRules.none')) when no prohibited expenses are enabled, instead of returning an empty string.

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 141 to 144 in d30f77c

	// If no expenses are prohibited, return empty string
	if (!prohibitedExpensesList.length) {
	return translate('workspace.rules.individualExpenseRules.none');
	}

What changes do you think we should make in order to solve the problem?

return an empty string ('') when no prohibited expenses are enabled, instead of showing "None".

if (!prohibitedExpensesList.length) {
    return '';
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021912298665900341481

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[dangrous]

can handle internal review since I worked on the original