[Due for payment 2025-04-25] [Desktop Navigation] Reports filters - Workspace filter is displayed when account has no workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+38409834@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3
App Component: Search

Action Performed:

Precondition:

• Account has no workspace.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Click Filters.
4. Click Workspace.

Expected Result:

Workspace filter will not be displayed when account has no workspace.

Actual Result:

Workspace filter is displayed when account has no workspace.
It opens a blank page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6796824_1744180129898.20250409_123149.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 08:14:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace filter is displayed when account has no workspace.
It opens a blank page.

What is the root cause of that problem?

We're always showing workspace filter:

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 560 to 562 in dc4e6b8

	} else if (key === CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID) {
	filterTitle = baseFilterConfig[key].getTitle(searchAdvancedFilters, policies);
	}

What changes do you think we should make in order to solve the problem?

Define shouldDisplayWorkspaceFilter and early return if not:

 const nonPersonalPolicies = Object.values(policies)
        .filter((policy): policy is NonNullable<Policy> => !!(policy && policy.type !== CONST.POLICY.TYPE.PERSONAL));
const shouldDisplayWorkspaceFilter = shouldDisplayFilter(Object.keys(nonPersonalPolicies).length);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

None
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[WojtekBoman]

Hey, I'll handle it as I'm the author of the offending PR: #59450. I believe we can demote the deploy blocker as it's hidden behind the leftHandBar beta