[Due for payment 2025-05-28] [$250] Accounting - Export to Sage Intacct appears while Sage is in authentication error

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #59718
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Apple iPhone 12 Pro / iOS 18.4
App Component: Other

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Incognito window: Log in with a new Gmail account using Chrome Incognito
3. Normal window: Log in with the same account using Chrome normal window
4. Incognito window: Create a workspace
5. Incognito window: Navigate to Workspace settings - More features
6. Incognito window: Enable "Accounting"
7. Incognito window: Navigate to Workspace settings - Accounting
8. Incognito window: Connect to Sage Intacct with invalid credentials and stop when "Can’t connect to Sage Intacct due to an authentication error." appears
9. Normal window: Navigate to the workspace chat
10. Normal window: Create a manual expense with any amount
11. Normal window: Submit the expense
12. Normal window: Approve the expense
13. Normal window: Pay the expense "Elsewhere"

Expected Result:

The button should only appear if a connection is established.

Actual Result:

"Export to Sage Intacct" button appears while Sage Intacct is in authentication error state.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6795789_1744098849264.bandicam_2025-04-08_09-44-21-992.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909909773376613538
• Upwork Job ID: 1909909773376613538
• Last Price Increase: 2025-04-16
• Automatic offers:
• mkzie2 | Contributor | 107005426

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 13:29:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting - Export to Sage Intacct appears while Sage is in authentication error

What is the root cause of that problem?

We are getting the connectedIntegration even if there is connection error

App/src/components/ReportActionItem/ReportPreview.tsx

Line 470 in c53e6a9

const connectedIntegration = getConnectedIntegration(policy);

What changes do you think we should make in order to solve the problem?

We should add a check here hasAuthenticationError and update shouldShowExportIntegrationButton
here

App/src/components/ReportActionItem/ReportPreview.tsx

Line 472 in c53e6a9

const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && isAdmin && canBeExported(iouReport);

const hasAuthenticationError = connectedIntegration ? policy?.connections?.[connectedIntegration]?.lastSync?.isAuthenticationError : undefined;

const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && !hasAuthenticationError && isAdmin && canBeExported(iouReport);

if there is a connection error then return undefined

We should do the same on MoneyReportHeader

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

we can use this function to get the AuthenticationError and prevent ExportIntegration button on header and report preview.

App/src/libs/actions/connections/index.ts

Line 353 in c53e6a9

function isAuthenticationError(policy: OnyxEntry<Policy>, connectionName: PolicyConnectionName) {

to get the AuthenticationError then use in shouldShowExportIntegrationButton
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal updated

Added alternative solution

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Export to Sage Intacct" button appears while Sage Intacct is in authentication error state.

What is the root cause of that problem?

The export button is always shown if the connectedIntegration exists. If we enter invalid credentail, connectedIntegration is not empty but has no data.

App/src/components/ReportActionItem/ReportPreview.tsx

Line 472 in c102d5c

const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && isAdmin && canBeExported(iouReport);

What changes do you think we should make in order to solve the problem?

This bug is also happening on MoneyReportHeader. I think the best way is we can create a util like getValidConnectedIntegration, this function will return the valid connection (the connection doesn't have authentication error or other conditions that we can ensure is a valid connected integration).

function getValidConnectedIntegration(policy: Policy | undefined, accountingIntegrations?: ConnectionName[]) {
    return (accountingIntegrations ?? Object.values(CONST.POLICY.CONNECTIONS.NAME)).find((integration) => !!policy?.connections?.[integration] && !isAuthenticationError(policy, integration));
}

And then we can use it here and here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a minor UI bug, so I don't think we need to add the test.

What alternative solutions did you explore? (Optional)

We can fix this case by case by adding !isAuthenticationError checking to shouldShowExportIntegrationButton

App/src/components/MoneyReportHeader.tsx

Line 312 in c102d5c

const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && isAdmin && canBeExported(moneyRequestReport);

App/src/components/ReportActionItem/ReportPreview.tsx

Line 472 in c102d5c

const shouldShowExportIntegrationButton = !shouldShowPayButton && !shouldShowSubmitButton && connectedIntegration && isAdmin && canBeExported(iouReport);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909909773376613538

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[flaviadefaria]

Added the external label.

[ishpaul777]

reviewing tmrw