[Payment 2025-05-07][$250] Сhat - Tapping top-left arrow from "Hmm... it's not here" page directs to workspace list page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.23-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Slottwo1 hons2@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Chat Report View

Action Performed:

1. Go to https://staging.new.expensify.com
2. Open a chat
3. Send this link - https://staging.new.expensify.com/settings/workspaces/7AFB61A6FF5173AB/company-cards
4. Open the link
5. Tap device back button
6. Tap on the link
7. Tap on app's top left arrow

Expected Result:

On tapping device back button/app's top left arrow from "Hmm... it's not here" page, user must be directed to correct conversation page.

Actual Result:

On tapping device's back button from "Hmm... it's not here" page, user is directed to the correct conversation page. But, while tapping the app's top-left arrow from "Hmm... it's not here" page, user is directed to workspace list page instead of correct conversation page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910792267826464775
• Upwork Job ID: 1910792267826464775
• Last Price Increase: 2025-04-18
• Automatic offers:
• huult | Contributor | 107005243

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[yaqoob2ishaq4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping the top-left arrow on the "Hmm... it's not here" page redirects the user to the workspace list instead of the correct conversation.

What is the root cause of that problem?

The issue occurs because the HeaderWithBackButton component isn’t using Navigation.getTopmostReportId() to properly navigate back to the correct conversation.

What changes do you think we should make in order to solve the problem?

Page Address src/components/BlockingViews/FullPageNotFoundView.tsx

on line '90' add line

Pass the shouldNavigateToTopMostReport={true} prop to HeaderWithBackButton in FullPageNotFoundView.tsx to correctly identify and return the user to the top-most conversation.

<HeaderWithBackButton
  onBackButtonPress={onBackButtonPress}
  shouldShowBackButton={shouldShowBackButton}
  shouldDisplaySearchRouter={shouldDisplaySearchRouter}
  shouldNavigateToTopMostReport={true}
/>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Test that the back button correctly navigates to the conversation after the "Hmm... it's not here" page.
• Test that tapping the top-left arrow returns the user to the correct conversation.
• If the user deletes all messages, ensure the back button still navigates to the correct previous page

What alternative solutions did you explore? (Optional)

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When a user lands on the "Hmm... it's not here" page and taps the device's native back button, they are correctly navigated back to the conversation (report) page. However, when tapping the top-left back arrow in the app's UI, they are incorrectly navigated to the workspace list page instead of returning to the appropriate conversation page.

What is the root cause of that problem?

• The current logic in the AccessOrNotFoundWrapper component navigates users to /settings/workspaces if the policy is not accessible:

  App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

  Lines 94 to 97 in b86758a

  	if (isPolicyNotAccessible) {
  	Navigation.goBack(ROUTES.SETTINGS_WORKSPACES.route);
  	return;
  	}

  This logic does not differentiate between users arriving directly at a workspace route and those who were routed there via a conversation link, leading to incorrect navigation when using the app’s back arrow.

What changes do you think we should make in order to solve the problem?

• We should determine whether the user navigated to the "Hmm... it's not here" page by clicking a link from a report (conversation) page. If so, the app’s back button (top-left arrow) should also return them to the report page rather than to the workspace list.

• To achieve this, we can update the link navigation logic to pass along the current route as a backTo param:

  In src/libs/actions/Link.ts:

  
  Navigation.navigate(getUrlWithBackToParam(internalNewExpensifyPath as Route, Navigation.getActiveRoute()));
  

• Then, update the onBackButtonPress function in AccessOrNotFoundWrapper.tsx to handle the backTo param:

  
  onBackButtonPress={() => {
      if (isPolicyNotAccessible) {
          if (route.params.backTo) {
              Navigation.goBack(route.params?.backTo);
              return;
          }
          Navigation.goBack(ROUTES.SETTINGS_WORKSPACES.route);
          return;
      }
  
      Navigation.goBack(policyID && !isMoneyRequest ? ROUTES.WORKSPACE_OVERVIEW.getRoute(policyID) : undefined);
  }}
  

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

I;m struggling to reproduce on browsterstack but let's move forward!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910792267826464775