[Due for payment 2025-05-30] [$250] iOS - Video - Error message overlaps with video in video player

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+250302kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Other

Action Performed:

1. Launch ND or hybrid app.
2. Go to chat.
3. Go offline.
4. Tap + > Add attachment > Choose from gallery.
5. Select a video.
6. Go online.

Expected Result:

Error message will not appear after returning online.

Actual Result:

After returning online, the video player shows "An error occurred while trying to play this video". The error overlaps with the video.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6781132_1742871050683.ScreenRecording_03-25-2025_10-48-42_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021905710430446693231
• Upwork Job ID: 1905710430446693231
• Last Price Increase: 2025-04-18
• Automatic offers:
• linhvovan29546 | Contributor | 107058686

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Video - Error message overlaps with video in video player

What is the root cause of that problem?

The error message is displayed based on this condition. When playing a video while offline, the onError event is triggered, setting the hasError flag to true. However, when reconnecting, this flag is not reset, causing the error message to persist.

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Line 513 in dc8eb79

{hasError && !isBuffering && !isOffline && <VideoErrorIndicator isPreview={isPreview} />}

What changes do you think we should make in order to solve the problem?

I have two options to fix this issue:

1. Reset the hasError flag to false when the video loads:
   

   App/src/components/VideoPlayer/BaseVideoPlayer.tsx

   Lines 498 to 503 in dc8eb79

   	onLoad={() => {
   	if (!isCurrentlyURLSet || isUploading) {
   	return;
   	}
   	playVideo();
   	}}

                                            onLoad={() => {
                                                setHasError(false)
                                                if (!isCurrentlyURLSet || isUploading) {
                                                    return;
                                                }
                                                playVideo();
                                            }} 

2. Only set hasError to true if the video is being played while online(I prefer this option most).
   

   App/src/components/VideoPlayer/BaseVideoPlayer.tsx

   Lines 506 to 508 in dc8eb79

   	onError={() => {
   	setHasError(true);
   	}}

                                            onError={() => {
                                                if(isOffline){
                                                    return
                                                }
                                                setHasError(true);
                                            }}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, UI bug no need unit tests

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021905710430446693231

[CortneyOfstad]

Was able to recreate so getting eyes on this

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)