[Due for payment 2025-04-17] [$500][HIGH] Navigating to a thread from the Search page doesn’t take you to the chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-3
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @NikkiWines
Slack conversation (hyperlinked to channel name): Expensify-bugs

Action Performed:

1. Click the Search icon from the Inbox page
2. Search for text you know exists in a thread by searching for type:chat "", replacing with your search value
3. Click on the result in the search page
4. Click on the top chat in the thread to try and navigate to that thread in your inbox

Expected Result:

You’re routed to the message that you clicked on

Actual Result:

You’re routed to the most recent message in the channel that has the thread you clicked on

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2025-03-11.at.10.48.46.mov

Recording.1044.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900185525361353185
• Upwork Job ID: 1900185525361353185
• Last Price Increase: 2025-03-13
• Automatic offers:
• thelullabyy | Contributor | 106560190

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-12 01:12:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• You’re routed to the most recent message in the channel that has the thread you clicked on

What is the root cause of that problem?

• When clicking on the parent message, the logic in:
  

  App/src/pages/home/report/ReportActionItemParentAction.tsx

  Lines 133 to 137 in de07682

  	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID));
  	if (isVisibleAction && !isOffline) {
  	// Pop the chat report screen before navigating to the linked report action.
  	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID, ancestor.reportAction.reportActionID));
  	}

executes without verifying whether the click originates from the report RHP. As a result, calling:

App/src/pages/home/report/ReportActionItemParentAction.tsx

Line 136 in de07682

Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID, ancestor.reportAction.reportActionID));

triggers the navigation logic in:

App/src/libs/Navigation/Navigation.ts

Line 301 in de07682

navigationRef.current.dispatch({...StackActions.pop(distanceToPop), target: targetState.key});

which only performs a pop action. Since this does not append reportActionID to the parameters, it results in navigating to the most recent message in the channel containing the thread instead of the specific message that was clicked.

What changes do you think we should make in order to solve the problem?

• When clicking on the parent message, we need to handle cases where the click originates from the report RHP separately.

App/src/pages/home/report/ReportActionItemParentAction.tsx

Line 131 in de07682

const isVisibleAction = shouldReportActionBeVisible(ancestor.reportAction, ancestor.reportAction.reportActionID, canUserPerformWriteAction);

                                          const isVisibleAction = shouldReportActionBeVisible(ancestor.reportAction, ancestor.reportAction.reportActionID, canUserPerformWriteAction);
                                          if (isInNarrowPaneModal) {
                                              Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: ancestor.report.reportID, reportActionID: ancestor.reportAction.reportActionID}));
                                              return;
                                          }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Implement a utility function, navigateToParent.
  Verify that when isInNarrowPaneModal is true, the navigate function is called with the correct URL, ensuring it includes both reportID and reportActionID.

What alternative solutions did you explore? (Optional)

• An alternative option is to update:

App/src/pages/home/report/ReportActionItemParentAction.tsx

Lines 133 to 137 in de07682

	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID));
	if (isVisibleAction && !isOffline) {
	// Pop the chat report screen before navigating to the linked report action.
	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID, ancestor.reportAction.reportActionID));
	}

                                          if (isVisibleAction && !isOffline) {
                                              // Pop the chat report screen before navigating to the linked report action.
                                              Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID, ancestor.reportAction.reportActionID));
                                          } else {
                                              Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID));
                                          }

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900185525361353185

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mallenexpensify]

@eVoloshchak 👀 on the proposal above.
Adding status of HIGH cuz search is a feature that most people will use and if they can't find their way to a chat then search isn't really working. cc @luacmartins in case you have thoughts/ideas/tips here. (also.. while here, are there any others to tag for 👀 on search-related bugs? Don't wanna just blast you all the time.)