[Due for payment 2025-04-02] [$250] mWeb - Reports - User has to use device´s back button to access the results of a search.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes

Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Search

Action Performed:

1. Open the staging.new.expensify.com website.
2. Tap on "Reports" on the bottom of the screen.
3. Tap on "Search for something"
4. Input any search that will trigger a result.
5. When all the expenses are displayed again, use device´s back button.
6. Check the results displayed after this action.

Expected Result:

Results of a search should be displayed automatically after triggering the search.

Actual Result:

User has to use device´s back button after triggering a search in "Reports" to see the results.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Bug6766853_1741656257062.Results.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900530783250150549
• Upwork Job ID: 1900530783250150549
• Last Price Increase: 2025-03-14

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After entering a search, we need to go back to see the filtered search results.

What is the root cause of that problem?

When we submit the search input, submitSearch which navigates to search page is called twice.

App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Lines 158 to 173 in aef2182

	const submitSearch = useCallback(
	(queryString: SearchQueryString) => {
	const queryWithSubstitutions = getQueryWithSubstitutions(queryString, autocompleteSubstitutions);
	const updatedQuery = getQueryWithUpdatedValues(queryWithSubstitutions, queryJSON.policyID);
	if (!updatedQuery) {
	return;
	}
	Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: updatedQuery}));
	hideSearchRouterList?.();
	setIsAutocompleteListVisible(false);
	if (updatedQuery !== originalInputQuery) {
	clearAllFilters();
	setTextInputValue('');
	setAutocompleteQueryValue('');

First when the text input onSubmit is triggered, and the 2nd one is when the focused item on the list is pressed (by ENTER key).

App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Lines 197 to 199 in aef2182

	} else if (item.searchItemType === CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.SEARCH) {
	submitSearch(item.searchQuery);
	}

App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Lines 254 to 256 in aef2182

	onSubmit={() => {
	submitSearch(textInputValue);
	}}

The 2nd call has an empty query because we already clear it in submitSearch.

What changes do you think we should make in order to solve the problem?

For non-native platforms, we will ignore the onSubmit callback, so it will only rely on the focused item press.

App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

Lines 254 to 256 in aef2182

	onSubmit={() => {
	submitSearch(textInputValue);
	}}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900530783250150549

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

@mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!