[Due for payment 2025-04-08] [$250] Web - Features in Workspace LHN are not in the same order as in "More Features"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to
2. Go to a workspace
   3.Turn on all features in under "More features"
3. They should all appear in the LHN for the workspace
4. Observe that the order they are in does not match what's in "More features"

Expected Result:

The order of the items in the LHN should be in the same order as they are in "More features"

Actual Result:

The order of the items does not match the order in "More features"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6735499_1738871413743.Recording__566.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900313225358014821
• Upwork Job ID: 1900313225358014821
• Last Price Increase: 2025-03-13

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The order of the items does not match the order in "More features"

What is the root cause of that problem?

The order in the WorkspaceInitialPage isn't the same as WorkspaceMoreFeaturesPage

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 105 in 8eacd3d

const spendItems: Item[] = [

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 174 in 8eacd3d

const workspaceMenuItems: WorkspaceMenuItem[] = useMemo(() => {

What changes do you think we should make in order to solve the problem?

Reorder the feature in WorkspaceInitialPage to the same in WorkspaceMoreFeaturesPage

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 174 in 8eacd3d

const workspaceMenuItems: WorkspaceMenuItem[] = useMemo(() => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug no need the test

What alternative solutions did you explore? (Optional)

Reorder the feature in WorkspaceMoreFeaturesPage to the same in WorkspaceInitialPage

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

🚨 Edited by proposal-police: This proposal was edited at 2025-03-10 17:18:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Features in Workspace LHN are not in the same order as in "More Features"

What is the root cause of that problem?

We are not arranging the features displayed in the correct order.

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 174 in 8eacd3d

const workspaceMenuItems: WorkspaceMenuItem[] = useMemo(() => {

What changes do you think we should make in order to solve the problem?

We should rearrange the display

1. Move accounting to after per diem

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 296 to 305 in 8eacd3d

	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]) {
	protectedMenuItems.push({
	translationKey: 'workspace.common.accounting',
	icon: Sync,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING.getRoute(policyID)))),
	brickRoadIndicator: hasSyncError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
	screenName: SCREENS.WORKSPACE.ACCOUNTING.ROOT,
	highlighted: highlightedFeature === CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED,
	});
	}

2. Move workflow and rules to after Report feild

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 220 to 239 in 8eacd3d

	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED]) {
	protectedMenuItems.push({
	translationKey: 'workspace.common.workflows',
	icon: Workflows,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS.getRoute(policyID)))),
	screenName: SCREENS.WORKSPACE.WORKFLOWS,
	brickRoadIndicator: !isEmptyObject(policy?.errorFields?.reimburser ?? {}) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
	highlighted: highlightedFeature === CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED,
	});
	}
	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED]) {
	protectedMenuItems.push({
	translationKey: 'workspace.common.rules',
	icon: Feed,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_RULES.getRoute(policyID)))),
	screenName: SCREENS.WORKSPACE.RULES,
	highlighted: highlightedFeature === CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED,
	});
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Features in Workspace LHN are not in the same order as in "More Features"

What is the root cause of that problem?

• Refactor

What changes do you think we should make in order to solve the problem?

Here we have a list of items that we push in workspaceMenuItems

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 174 in ccc4d65

const workspaceMenuItems: WorkspaceMenuItem[] = useMemo(() => {

We should follow the order same as More features in smallScreenWidth

1. distanceRates
2. expensifyCard
3. companyCards
4. perDiem
5. accounting
6. categories
7. tags
8. taxes
9. reportFields
10. workflows
11. rules
12. invoices

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write unit test to

• Ensure that the function returns the expected base menu items, If shouldShowProtectedItems is true, ensure protected menu items are included

• Check that when a specific feature is enabled, its corresponding menu item appears in workspaceInitialPage

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900313225358014821

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)