[Due for payment 2025-03-21] [Due for payment 2025-03-17] [$250] Link - No "Copy URL to clipboard" menu when right-clicking on link

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Send google.com link.
4. Right click on the link.

Expected Result:

There will be a "Copy URL to Clipboard" menu when right-clicking on link.

Actual Result:

There is no "Copy URL to clipboard" menu when right-clicking on link.
On mobile layout, there is a menu but with no option when right-clicking on the link.

The same issue also happens when right-click on external link (Domains and Help) in Settings.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6763572_1741318885726.iOS.mp4

Bug6763572_1741318783423.20250307_113824.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897929880859674863
• Upwork Job ID: 1897929880859674863
• Last Price Increase: 2025-03-07
• Automatic offers:
• ZhenjaHorbach | Reviewer | 106422704
• daledah | Contributor | 106422705

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-07 08:53:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no "Copy URL to clipboard" menu when right-clicking on link.
On mobile layout, there is a menu but with no option when right-clicking on the link.

What is the root cause of that problem?

This line:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 208 in fb79730

reportID &&

Added in this PR to handle lint error, but since we don't need reportID for copying the URL, we don't pass reportID to showContextMenu anywhere. Example of some places:

App/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

Line 51 in fb79730

ReportActionContextMenu.showContextMenu(isEmail ? CONST.CONTEXT_MENU_TYPES.EMAIL : CONST.CONTEXT_MENU_TYPES.LINK, event, href, linkRef.current);

App/src/components/MenuItemList.tsx

Line 69 in fb79730

ReportActionContextMenu.showContextMenu(CONST.CONTEXT_MENU_TYPES.LINK, event, link, popoverAnchor.current);

After the PR is merged, there's still no bugs appeared. This is because before this PR, we set default reportIDRef.current as -1:

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

Line 35 in ff2520e

const reportIDRef = useRef('-1');

Which is truthy. After that PR, reportIDRef.current defaults as undefined, which is falsy.

So filteredContextMenuActions will return empty array when right click on link.

What changes do you think we should make in order to solve the problem?

We should remove this line:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 208 in fb79730

reportID &&

And handle reportID value inside shouldShow. It should only affect some actions that actually need it, for example some comment actions like "Reply in thread" or "Delete"

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.