[Due for payment 2025-04-16] [$250] Hybrid Android - More features - No padding on OS buttons when online

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 57534
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): testexpensify9+od1@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung A15, Android 14
App Component: Workspace Settings

Action Performed:

1. Open Hybrid app
2. Log in
3. Tap on 'Settings' > 'Workspaces' > Any own WS > 'More Features'

Expected Result:

The OS buttons should have the same padding as offline.

Actual Result:

There is no padding on OS buttons when the user is online.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/a29e7ae1-cd1d-4172-808b-ac88fc884819

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897015898509608541
• Upwork Job ID: 1897015898509608541
• Last Price Increase: 2025-03-18
• Automatic offers:
• huult | Contributor | 106651652

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no padding on OS buttons when the user is online.

What is the root cause of that problem?

We set includeSafeAreaPaddingBottom to false here:

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 450 in 7bda731

includeSafeAreaPaddingBottom={false}

What changes do you think we should make in order to solve the problem?

Remove this line

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 450 in 7bda731

includeSafeAreaPaddingBottom={false}

because ScreenWrapper defaults includeSafeAreaPaddingBottom to true.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897015898509608541

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)