[Due for payment 2025-03-21] [$250] Workspace - Missing workspace name in "You missed the party in" in archived #admins room

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.5-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace settings > Overview.
4. Click Share.
5. Click #admins.
6. Send a message in #admins.
7. Go to workspace settings.
8. Delete the workspace.
9. Go back to #admins.

Expected Result:

"You missed the party in" message will include the workspace name.

Actual Result:

The workspace name is missing and only shows — "You missed the party in , there's nothing to see here."

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6753390_1740468193638.20250225_151332.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895135725269863089
• Upwork Job ID: 1895135725269863089
• Last Price Increase: 2025-02-27

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"You missed the party in" message is missing the workspace name - You missed the party in , there's nothing to see here.

What is the root cause of that problem?

we don't add workspace name here

App/src/languages/en.ts

Line 720 in eaa3be4

beginningOfArchivedRoomPartOne: 'You missed the party in ',

What changes do you think we should make in order to solve the problem?

1. Update this to add params workspace name

beginningOfArchivedRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAdminRoomPartOneParams) => `You missed the party in ${workspaceName}`,

2. And pass workspace name here

App/src/libs/SidebarUtils.ts

Line 742 in eaa3be4

welcomeMessage.phrase1 = translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');

OPTIONAL: If we want bold Workspace name then we can separate it and do the same as this PR

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace name is missing from the archived admins room welcome message.

What is the root cause of that problem?

This happens after #57078. If the report is archived, we will have 2 phrases.

App/src/libs/SidebarUtils.ts

Lines 741 to 743 in d97f1b4

	if (isArchivedReportWithID(report?.reportID)) {
	welcomeMessage.phrase1 = translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');
	welcomeMessage.phrase2 = translateLocal('reportActionsView.beginningOfArchivedRoomPartTwo');

The 1st phrase is You missed the party in ,. Previously, if it's archived, we use this to show the text. 1st phrase, report name, 2nd phrase.

App/src/components/ReportWelcomeText.tsx

Lines 155 to 175 in d97f1b4

	{isChatRoom &&
	(!isInvoiceRoom || isArchivedRoom) &&
	!isAdminRoom &&
	(welcomeMessage?.messageHtml ? (
	<View style={styles.renderHTML}>
	<RenderHTML html={welcomeMessage.messageHtml} />
	</View>
	) : (
	<Text>
	<Text>{welcomeMessage.phrase1}</Text>
	{welcomeMessage.showReportName && (
	<Text
	style={[styles.textStrong]}
	onPress={navigateToReport}
	suppressHighlighting
	>
	{getReportName(report)}
	</Text>
	)}
	{welcomeMessage.phrase2 !== undefined && <Text>{welcomeMessage.phrase2}</Text>}
	</Text>

But after the PR, we ignore it if it's an admin room and instead, use this to show 4 phrases of the admin room if not archived.

App/src/components/ReportWelcomeText.tsx

Lines 177 to 184 in d97f1b4

	{isChatRoom && isAdminRoom && (
	<Text>
	<Text>{welcomeMessage.phrase1}</Text>
	{welcomeMessage.phrase2 !== undefined && <Text style={styles.textStrong}>{welcomeMessage.phrase2}</Text>}
	{welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
	{welcomeMessage.phrase4 !== undefined && <Text>{welcomeMessage.phrase4}</Text>}
	</Text>
	)}

What changes do you think we should make in order to solve the problem?

We need to move the admin room check to the same place as invoice room check.

App/src/components/ReportWelcomeText.tsx

Lines 155 to 159 in d97f1b4

	{isChatRoom &&
	(!isInvoiceRoom || isArchivedRoom) &&
	!isAdminRoom &&
	(welcomeMessage?.messageHtml ? (
	<View style={styles.renderHTML}>

{isChatRoom && ((!isInvoiceRoom && !isAdminRoom) || isArchivedRoom) &&

Then, don't show this if it's an archived room.

App/src/components/ReportWelcomeText.tsx

Lines 177 to 184 in d97f1b4

	{isChatRoom && isAdminRoom && (
	<Text>
	<Text>{welcomeMessage.phrase1}</Text>
	{welcomeMessage.phrase2 !== undefined && <Text style={styles.textStrong}>{welcomeMessage.phrase2}</Text>}
	{welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
	{welcomeMessage.phrase4 !== undefined && <Text>{welcomeMessage.phrase4}</Text>}
	</Text>
	)}

{isChatRoom && isAdminRoom && !isArchivedRoom &&

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-25 14:16:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Missing workspace name in "You missed the party in" in archived #admins room

What is the root cause of that problem?

Currently, we are not passing the policyName to beginningOfArchivedRoomPartOne key here

App/src/languages/en.ts

Lines 720 to 721 in 9abc56b

	beginningOfArchivedRoomPartOne: 'You missed the party in ',
	beginningOfArchivedRoomPartTwo: ", there's nothing to see here.",

That show the welcome text without workspace Name

What changes do you think we should make in order to solve the problem?

Add a new translation that will display policy name,
we already have beginningOfArchivedRoomPartTwo so we will change that to beginningOfArchivedRoomPartThree

beginningOfArchivedRoomPartOne: 'You missed the party in ',
beginningOfArchivedRoomPartTwo: ({workspaceName, isAdminRoom}: beginningOfArchivedRoomPartTwo) =>`${isAdminRoom ? workspaceName : ''}`,
beginningOfArchivedRoomPartThree: ", there's nothing to see here.",

Add new types in languages/params.ts

type beginningOfArchivedRoomPartTwo = {
    workspaceName: string;
    isAdminRoom: boolean;
};

From getRoomWelcomeMessage we will pass the policyName and explicitly check if it's AdminRoom so that we can hide the workspace name on other rooms where we display reportName in welcome message

const isAdminRoom = isAdminRoomReportUtils(report);

if (isArchivedReportWithID(report?.reportID)) {
    welcomeMessage.phrase1 = translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');
    welcomeMessage.phrase2 = translateLocal('reportActionsView.beginningOfArchivedRoomPartTwo', {workspaceName, isAdminRoomChat})
    welcomeMessage.phrase3 = translateLocal('reportActionsView.beginningOfArchivedRoomPartThree');

And pass this third phrase for non admin rooms rooms here

App/src/components/ReportWelcomeText.tsx

Lines 174 to 183 in e12e4b3

	{welcomeMessage.phrase2 !== undefined && <Text>{welcomeMessage.phrase2}</Text>}
	</Text>
	))}
	{isChatRoom && isAdminRoom && (
	<Text>
	<Text>{welcomeMessage.phrase1}</Text>
	{welcomeMessage.phrase2 !== undefined && <Text style={styles.textStrong}>{welcomeMessage.phrase2}</Text>}
	{welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}
	{welcomeMessage.phrase4 !== undefined && <Text>{welcomeMessage.phrase4}</Text>}
	</Text>

add this line bellow 174

{welcomeMessage.phrase3 !== undefined && <Text>{welcomeMessage.phrase3}</Text>}

we already displaying the phrase3 for admin room so no need to change anything there

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A UI issue

What alternative solutions did you explore? (Optional)

Results

[CortneyOfstad]

Adjusted the Actual Result in the main GH comment to make this more clear. Was able to recreate, so getting eyes on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895135725269863089