[Due for payment 2025-03-24] [$250] Debug-When no results found for searched term, "no results found" message is not displayed

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: User Settings

Action Performed:

Pre-condition: Tap settings - troubleshoot -Enable debug mode

1. Go to https://staging.new.expensify.com/home
2. Open a room chat which has few previous chats
3. Tap header - debug- actions
4. In search field, enter any parameters so that no results are shown

Expected Result:

In debug- report page, on search field when no results are found for the searched term, " no results found" message must be displayed.

Actual Result:

In debug-report page, on search field when no results are found for the searched term, " no results found" message is not displayed.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6751655_1740321780753.Screenrecorder-2025-02-23-20-03-40-214.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021896576566003528227
• Upwork Job ID: 1896576566003528227
• Last Price Increase: 2025-03-03
• Automatic offers:
• daledah | Contributor | 106415759

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Debug-When no results found for searched term, "no results found" message is not displayed

What is the root cause of that problem?

SelectionList component in DebugReportActions does not have an empty state configured.

App/src/pages/Debug/Report/DebugReportActions.tsx

Lines 83 to 91 in 0b6d1a0

	<SelectionList
	sections={[{data: searchedReportActions}]}
	listItemTitleStyles={styles.fontWeightNormal}
	textInputValue={searchValue}
	textInputLabel={translate('common.search')}
	onChangeText={setSearchValue}
	onSelectRow={(item) => Navigation.navigate(ROUTES.DEBUG_REPORT_ACTION.getRoute(reportID, item.reportActionID))}
	ListItem={RadioListItem}
	/>

What changes do you think we should make in order to solve the problem?

We should update DebugReportActions to display a "No results found" message when the searchedReportActions array is empty.

            <SelectionList
                sections={[{data: searchedReportActions}]}
                listItemTitleStyles={styles.fontWeightNormal}
                textInputValue={searchValue}
                textInputLabel={translate('common.search')}
                onChangeText={setSearchValue}
                onSelectRow={(item) => Navigation.navigate(ROUTES.DEBUG_REPORT_ACTION.getRoute(reportID, item.reportActionID))}
                ListItem={RadioListItem}
                headerMessage={searchedReportActions.length === 0 ? translate('common.noResultsFound') : undefined}
                headerMessageStyle={[styles.textAlignCenter, styles.ph5]}
            />

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-05 14:53:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• In debug-report page, on search field when no results are found for the searched term, " no results found" message is not displayed.

What is the root cause of that problem?

• The headerMessage prop is missing, which prevents the display of messages like "No results found" in the following file:
  

  App/src/pages/Debug/Report/DebugReportActions.tsx

  Line 83 in 0b6d1a0

  <SelectionList

What changes do you think we should make in order to solve the problem?

• We should introduce the headerMessage prop:

headerMessage={getHeaderMessageForNonUserList(searchedReportActions.length > 0, debouncedSearchValue)}

This ensures that when a search term is entered but no results are found, the appropriate message is displayed. We did it in other list such as category, tax, ...

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

To test the feature, we can:

1. Render the /debug/report/${reportID}/actions page.
2. Simulate typing any text in the search input that results in no matches.
3. Verify that the "No results found" message is displayed.

What alternative solutions did you explore? (Optional)

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-24 13:52:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Debug-When no results found for searched term, "no results found" message is not displayed

What is the root cause of that problem?

Currently we are missing a param headerMessage here

App/src/pages/Debug/Report/DebugReportActions.tsx

Lines 83 to 91 in 3658843

	<SelectionList
	sections={[{data: searchedReportActions}]}
	listItemTitleStyles={styles.fontWeightNormal}
	textInputValue={searchValue}
	textInputLabel={translate('common.search')}
	onChangeText={setSearchValue}
	onSelectRow={(item) => Navigation.navigate(ROUTES.DEBUG_REPORT_ACTION.getRoute(reportID, item.reportActionID))}
	ListItem={RadioListItem}
	/>

that is responsible to display headerMessages below text input

What changes do you think we should make in order to solve the problem?

We should add a new const

    const headerMessage = debouncedSearchValue.trim() && searchedReportActions.length === 0 ? translate('common.noResultsFound') : '';

searchedReportActions.length === 0 will check if we don't have any result, so we can safely display No results Found

and pass it here

<SelectionList
                sections={[{data: searchedReportActions}]}
                listItemTitleStyles={styles.fontWeightNormal}
                textInputValue={searchValue}
                textInputLabel={translate('common.search')}
                onChangeText={setSearchValue}
                headerMessage={headerMessage}
                onSelectRow={(item) => Navigation.navigate(ROUTES.DEBUG_REPORT_ACTION.getRoute(reportID, item.reportActionID))}
                ListItem={RadioListItem}
            />

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Ul issue, N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Results

Screen.Recording.2025-02-24.at.6.46.01.PM.mov

[github-actions]

⚠️ @samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[OfstadC]

Was OoO - will test tomorrow morning to get this moving

[OfstadC]

I don't have the "debug" option. is there something I need to do to pull this option up? 😅