[Due for payment 2025-03-13] [$250] Workspace - Background changes when reloading in Downgrade or Upgrade workspace page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): applausetester+bg@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung
App Component: Workspace Settings

Action Performed:

1. Login to any account
2. Create a workspace
3. Navigate to Subscription > Click on Control
4. On the Upgrade page Refresh

Expected Result:

Background remains in settings page

Actual Result:

Background changes to Inbox page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6750566_1740191156168.w_0e44cdadd61de8e5b2c1c23e23b91880e5fa1c23-2025-02-22_02_24_07.507.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894129018066683747
• Upwork Job ID: 1894129018066683747
• Last Price Increase: 2025-02-24
• Automatic offers:
• thelullabyy | Contributor | 106296278

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-22 12:43:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Background changes to Inbox page

What is the root cause of that problem?

We don't add a backTo param to the route when open workspace upgrade and downgrade pages in here, here, here and here

So the logic to get the overlay screen is not called:

App/src/libs/Navigation/helpers/getAdaptedStateFromPath.ts

Line 46 in 0b6d1a0

// Check for backTo param. One screen with different backTo value may need different screens visible under the overlay.

What changes do you think we should make in order to solve the problem?

We can add a backTo param to the route when open the workspace upgrade and downgrade page. For example:

App/src/pages/settings/Subscription/SubscriptionPlan/index.tsx

Line 100 in 0b6d1a0

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(ownerPolicies.at(0)?.id));

            Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(ownerPolicies.at(0)?.id, undefined, Navigation.getActiveRoute()));

With the WORKSPACE_UPGRADE, we already have backTo param in its route method. We need to do the same with WORKSPACE_DOWNGRADE and make sure both of them always add the backTo params to the route if backTo param is defined.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894129018066683747

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@thelullabyy's proposal LGTM!

🎀👀🎀 C+ reviewed