[Due for payment 2025-03-28] [$250][Back nav] Workspace - On completing transfer ownership flow, tapping back button redirects to blank page

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.3-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home (login with gmail)
2. Go to workspace settings - members - invite a member
3. Set the member as admin
4. Login as invited user
5. Go to workspace settings - members
6. Tap on user with owner tag
7. Tap transfer ownership and complete the flow
8. Tap app's back button

Expected Result:

In gmail account, after completing transfer ownership flow tapping app's back button must not direct to blank page.

Actual Result:

In gmail account, after completing transfer ownership flow tapping app's back button directs to blank page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894630551371598920
• Upwork Job ID: 1894630551371598920
• Last Price Increase: 2025-02-26
• Automatic offers:
• thelullabyy | Contributor | 106399492

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-21 14:28:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - On completing transfer ownership flow, tapping back button redirects to blank page

What is the root cause of that problem?

When pressing on transfer owner we are navigated with :error param of amountOwed then on the response of RequestWorkspaceOwnerChange API we will navigate to a route with another appropriate error param here which will leave two screens in the stack above the members details page so on success page on pressing got it we are only going back and navigating to the members page here

App/src/pages/workspace/members/WorkspaceOwnerChangeSuccessPage.tsx

Lines 27 to 29 in b9c5fd3

	MemberActions.clearWorkspaceOwnerChangeFlow(policyID);
	Navigation.goBack();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));

So there will be amountOwed screen in the stack above another member details screen below the stack so when we go back we will go back to those screens in order 👍

What changes do you think we should make in order to solve the problem?

As we finished on the transfer flow we should goBack to the member details page below the stack instead so that all the screens in the process of the transfer flow will be removed from the stack.

        Navigation.goBack(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));

We do have the same problem here and here here too

Additionally or optionally we can consider removing the old amountOwed screen from stack when renavigating here by adding a goBack before navigating.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can render WorkspaceOwnerChangeSuccessPage fire press event on the back button and assert that goBack is called with an argument of ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID)

What alternative solutions did you explore? (Optional)

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-27 07:58:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• In gmail account, after completing transfer ownership flow tapping app's back button directs to blank page.

What is the root cause of that problem?

• When the user clicks "Transfer Owner", they are navigated to the ROUTES.WORKSPACE_OWNER_CHANGE_CHECK route with the default error parameter set to amountOwed. At the same time, the app attempts to fetch the correct error using requestWorkspaceOwnerChange(policyID):
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Lines 252 to 253 in 0b6d1a0

  	requestWorkspaceOwnerChange(policyID);
  	Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_CHECK.getRoute(policyID, accountID, 'amountOwed' as ValueOf<typeof CONST.POLICY.OWNERSHIP_ERRORS>));

• On the Workspace Owner Change Check page, once the correct error is retrieved from policy?.errorFields?.changeOwner, the user is navigated again to ROUTES.WORKSPACE_OWNER_CHANGE_CHECK with the updated error parameter. As a result, two instances of ROUTES.WORKSPACE_OWNER_CHANGE_CHECK end up in the navigation stack.

• Finally, on the Workspace Owner Change Success page, clicking the "Got it" button triggers:

App/src/pages/workspace/members/WorkspaceOwnerChangeSuccessPage.tsx

Lines 28 to 29 in b9c5fd3

	Navigation.goBack();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));

• However, this is not sufficient because, as mentioned earlier, there are two instances of ROUTES.WORKSPACE_OWNER_CHANGE_CHECK in the stack. Calling goBack once only removes the second instance, leaving the first one still in the stack.

• It leads to the actual behavior, "In gmail account, after completing transfer ownership flow tapping app's back button directs to blank page.".

What changes do you think we should make in order to solve the problem?

two instances of ROUTES.WORKSPACE_OWNER_CHANGE_CHECK end up in the navigation stack

• Fixing the above issue will not only resolve the bug but also improve the app's behavior by eliminating the redundancy of adding the same screen to the stack twice. To fix this, we simply need to update the error parameter here instead of navigating:
  

  App/src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx

  Line 59 in 0b6d1a0

  Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_CHECK.getRoute(policyID, accountID, changeOwnerErrors.at(0) as ValueOf<typeof CONST.POLICY.OWNERSHIP_ERRORS>));

            Navigation.setParams({error: changeOwnerErrors.at(0)});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Mock the Onyx data to simulate the current user as an admin of a workspace. Render the workspace member page for the workspace owner. Simulate a press action on the "Transfer Owner" button using fireEvent(..., press). Wait for the transition to complete, and then verify that the error parameter in the route updates from amountOwed to another error, such as duplicateSubscription.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894630551371598920

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)