[Due for payment 2025-05-14] Room - Mentions is not highlighted when a space doesn't preceed it.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Chat Report View

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a room chat
3. Enter below (not a code block)
   #45:#45:#45
#45 #45 #45
4. Note the text which is highlighted
5. Send the message
6. In whisper message, tap yes
7. Note all text is highlighted

Expected Result:

Mentions must be highlighted in the same way before & after invited.

Actual Result:

Mentions is not highlighted in the same way before & after invited.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6748670_1740029655778.Screenrecorder-2025-02-20-10-51-14-734.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895106648159281755
• Upwork Job ID: 1895106648159281755
• Last Price Increase: 2025-02-27
• Automatic offers:
• truph01 | Contributor | 106481376

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Mentions is not highlighted in the same way before & after invited.

What is the root cause of that problem?

• The regex to match the room mention markdown is (see line):

/(?<=^[*~_]?|[ \n][*~_]?)(#[\p{Ll}0-9-]{1,99})(?![^<]*(?:<\/pre>|<\/code>|<\/a>))/gimu

Text :#report does not match the above regex.

What changes do you think we should make in order to solve the problem?

• We should update the regex to something like /(?<=^[*~_]?|[ \n:*~_])(#([\p{Ll}0-9-]{1,99}))(?=[^<]*(?:<\/pre>|<\/code>|<\/a>)|[: \n]|$)/gimu or /(?<=^[*~_:]?|[ \n][*~_:]?|[:#])(#[\p{Ll}0-9-]{1,99})(?![^<]*(?:<\/pre>|<\/code>|<\/a>))/gimu, so :#report can be converted to :<mention-report>report</mention-report>.

This change need to be apply to the expensify-common.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Create test for the replace function to make sure :#report can be converted to :<mention-report>report</mention-report>.

What alternative solutions did you explore? (Optional)

• Here:

App/src/pages/home/report/PureReportActionItem.tsx

Line 960 in 9daafa3

<MentionReportContext.Provider value={mentionReportContextValue}>

we can pass exactlyMatch: true to the context value, so we only highlight the message after creating room.

[melvin-bot]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@twisterdotcom Huh... This is 4 days overdue. Who can take care of this?

[twisterdotcom]

57195.mp4

I don't understand this issue. It works fine for me.

[truph01]

@twisterdotcom This bug is related to our markdown library, so it appears everywhere that markdown is used. Since the behavior mentioned in the OP can no longer be reproduced (as it was fixed in another PR), the issue can still be observed on a different page. In the image below, I saved the description:

#45:#45:#45

to the transaction description, and only the first #45 is highlighted, the rest are displayed are normal text.

[twisterdotcom]

What is the behaviour we're discussing here though? We're saying it should highlight even if a character proceeds the #?

If so, why do you believe that should be the case? I suppose you are correct that Slack does do this:

[twisterdotcom]

I missed that before, so I agree, I can recreate it now: