[Due for payment 2025-03-24] [$250] Web - Deeplink - The web doesn't open the Concierge chat when login with existing account

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5579888&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): luongquocvu92@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Other

Action Performed:

1. Log in with your existing account
2. Log out of NewDot
3. Go to https://staging.new.expensify.com/concierge
4. Verify that you are taken to the login screen
5. Log in to NewDot

Expected Result:

Verify you're navigated to the Concierge chat after login

Actual Result:

The web doesn't open the concierge chat after login with an existing account

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021899044463291083754
• Upwork Job ID: 1899044463291083754
• Last Price Increase: 2025-03-10

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The web doesn't open the concierge chat after login with an existing account

What is the root cause of that problem?

We have the logic to handle the deeplink here. When we link in the concierge chat the report is undefined because we cannot detect the reportID from this link. Then we navigate to the last access report

App/src/libs/actions/Report.ts

Lines 2952 to 2955 in a4cbb1d

	if (!report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);

What changes do you think we should make in order to solve the problem?

We should check if the route is the concierge chat then we will navigate to this route and the ConciergePage will handle the logic to navigate to concierge chat

if (!report && route !== ROUTES.CONCIERGE) {

App/src/libs/actions/Report.ts

Lines 2952 to 2955 in a4cbb1d

	if (!report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deeplink - The web doesn't open the Concierge chat when login with existing account

What is the root cause of that problem?

For Deeplink initially we check either the report available in collection if not then this logic triggers

App/src/libs/actions/Report.ts

Lines 2952 to 2963 in 22c5324

	if (!report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
	Navigation.navigate(lastAccessedReportRoute, CONST.NAVIGATION.ACTION_TYPE.PUSH);
	return;
	}
	navigateToConciergeChat(false, () => true, CONST.NAVIGATION.ACTION_TYPE.PUSH);
	return;
	}
	Navigation.navigate(route as Route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

we will always navigate to lastAccessedReportRoute because we not not checking if the route is concierge chat, and because the navigation for concierge chat is outside this condition

if (lastAccessedReportID) {
const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
Navigation.navigate(lastAccessedReportRoute, CONST.NAVIGATION.ACTION_TYPE.PUSH);
return;
}

so it does not navigate to concierge

What changes do you think we should make in order to solve the problem?

here

if (lastAccessedReportID) {

we should explicitly check either the route is not concierge chat
route !== ROUTES.CONCIERGE

and update this condition to

if (lastAccessedReportID && route !== ROUTES.CONCIERGE) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The concierge page doesn't open after log in if we open it while logged out.

What is the root cause of that problem?

We have a logic to check if the report from the URL reportID exists or not.

App/src/libs/actions/Report.ts

Lines 2946 to 2958 in a0a2609

	// Check if the report exists in the collection
	const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
	// If the report does not exist, navigate to the last accessed report or Concierge chat
	if (!report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
	Navigation.navigate(lastAccessedReportRoute);
	return;
	}
	navigateToConciergeChat(false, () => true);
	return;
	}

If it doesn't exist, then we navigate the user to the last accessed report or concierge chat. However, not all URL has a reportID, for example, /concierge in this case (or others, such as settings, workspace, etc.).

What changes do you think we should make in order to solve the problem?

We should check if the reportID exists on the URL or not before executing the logic. Only if reportID exists on the URL and the report object doesn't exist, then we navigate to the last accessed report.

if (reportID && !report) {
    ...
}

Or we can be more specific by checking if the route is a report route.

if (route.replace(/\/+$/, '') === ROUTES.REPORT_WITH_ID.getRoute(reportID, route.split('/').at(2)) && !report) {
    ...
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[samranahm]

@anmurali Would you mind taking a look at the proposal when you have a moment

[melvin-bot]

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@anmurali 12 days overdue. Walking. Toward. The. Light...