[Due for payment 2025-02-18] [$250] Incorrect border color on subscript avatar in "Choose recipient" page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.91-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Navigate to create expense from Green fab
2. Enter any amount and click Next
3. In choose recipient page observe the subscript avatar

Expected Result:

The border color should be lighter to match the background.

Actual Result:

The border color is not matching with the background.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884807153816511629
• Upwork Job ID: 1884807153816511629
• Last Price Increase: 2025-02-03

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect border color on subscript avatar

What is the root cause of that problem?

This bug can only be reproduced when hovering into an item and hovering out.

We are defining the set hover logic here


App/src/hooks/useHover.ts

Lines 7 to 10 in b38c287

	bind: {
	onMouseEnter: () => setHovered(true),
	onMouseLeave: () => setHovered(false),
	},

And use it as props in BaseListItem



https://github.com/Expensify/App/blob/b38c287ac4e462e5c6db786d9443069fac926f04/src/components/SelectionList/BaseListItem.tsx#L77


But onMouseLeave is not a valid props


What changes do you think we should make in order to solve the problem?




We should use props onHoverIn and onHoverOut

       bind: {
            onHoverIn: () => setHovered(true),
            onHoverOut: () => setHovered(false),
        },

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884807153816511629

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

Upwork job price has been updated to $125

[VictoriaExpensify]

I think this is a very simple fix so I'm reducing the bounty to $125. If I've misunderstood the complexity of this, please let me know and I can reassess.