[Due for payment 2025-02-25] [$250] Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

Pre-condition: set app language to spanish

1. Go to https://staging.new.expensify.com/home
2. Open workspace chat
3. Submit 2 expenses
4. Delete the second expense
5. Note the system message in expense report
6. On top from drowdown, select pay elsewhere
7. Pay the expense
8. Note the system message

Expected Result:

In spanish language, while deleting and paying expense, currency must be displayed in a consistent way.

Actual Result:

In spanish language, while deleting and paying expense, currency displayed in a inconsistent way.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6725804_1738042695312.Screenrecorder-2025-01-28-11-01-22-15_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885423763093241359
• Upwork Job ID: 1885423763093241359
• Last Price Increase: 2025-01-31
• Automatic offers:
• shubham1206agra | Reviewer | 105992976

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - In spanish language, while deleting&paying expense, currency display is inconsistent #55837

What is the root cause of that problem?

In function getDeletedTransactionMessage, we are putting currency before amount

App/src/libs/ReportUtils.ts

Lines 5143 to 5146 in e411125

	const message = translateLocal('iou.deletedTransaction', {
	amount: `${currency}${amount}`,
	merchant: deletedTransactionOriginalMessage.merchant ?? '',
	});

What changes do you think we should make in order to solve the problem?

We should use convertToDisplayString like we did with pay transaction

    const amount = Math.abs(deletedTransactionOriginalMessage.amount ?? 0) / 100;
    const currency = deletedTransactionOriginalMessage.currency ?? ''
    const formattedAmount = convertToDisplayString(amount, currency) ?? '';
    const message = translateLocal('iou.deletedTransaction', {
        amount: formattedAmount,
        merchant: deletedTransactionOriginalMessage.merchant ?? '',
    });

Note: We should synchronize all system messages with amount using formattedAmount

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885423763093241359

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[shubham1206agra]

@Themoonalsofall's proposal looks good to me.

🎀👀🎀 C+ reviewed