[Payment Due May 7] [$250] Expense - Discard Changes modal not displayed when using device back button on Merchant field

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.86-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): ibellicotest+171@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

1. Open the staging.new.expensify.com website.
2. Click on the FAB and select "Create Expense"
3. Complete with any amount and click on "Next"
4. Select any Workspace.
5. Open "Merchant" field and write anything.
6. Tap on the app´s back button.
7. Check that a "Discard Changes" modal is displayed.
8. Open "Merchant" field again and write anything.
9. Use the device back button.
10. Check if a "Discard Changes" modal is displayed.
11. Repeat steps 5 to 10 but with "Description" field.

Expected Result:

"Discard Changes" modal should be displayed if the user returns to previous page using device back button.

Actual Result:

"Discard Changes" modal is not displayed when using device back button on "Merchant" or "Description" fields.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6714843_1736954744576.Modal.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879602279874226797
• Upwork Job ID: 1879602279874226797
• Last Price Increase: 2025-01-15
• Automatic offers:
• mkzie2 | Contributor | 105790576

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Discard Changes" modal is not displayed when using device back button on "Merchant" or "Description" fields.

What is the root cause of that problem?

The beforeRemove event is not triggered when using browser back button.

What changes do you think we should make in order to solve the problem?

We should only use beforeRemove for Native apps, for web browsers, we should leverage the popstate event as we have used in Modal:

App/src/components/Modal/index.tsx

Lines 50 to 53 in ffa60b7

	if (shouldHandleNavigationBack) {
	window.history.pushState({shouldGoBack: true}, '', null);
	window.addEventListener('popstate', handlePopStateRef.current);
	}

But if we do that, we need to introduce another prop onConfirm for DiscardChangesConfirmation to replace the usage of blockedNavigationAction:

App/src/pages/iou/request/step/DiscardChangesConfirmation.tsx

Line 44 in 53beacb

navigation.dispatch(blockedNavigationAction.current);

So, we need to create platform-specific DiscardChangesConfirmation which uses window's popstate event listener for web and beforeRemove for native apps. And use onConfirm prop on web to replace blockedNavigationAction.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should write test to make sure the modal is visible in both cases: browser back button (window.history.back()) and native back button (Navigation.goBack()).

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[michaelkwardrop]

I was able to reproduce

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879602279874226797

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

@mkzie2's proposal LGTM.
🎀👀🎀 C+ reviewed