[HOLD for payment 2025-01-21] [$250] Desktop - Track expense - Hmm... it's not here after selecting the Categorize it option

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.81-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5420258&group_by=cases:section_id&group_order=asc&group_id=309130
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.2
App Component: Other

Action Performed:

1. Open the app
2. Login with a user with workspaces
3. Delete all WS
4. Submit a track expense in the self DM
5. Click on Categorize it in the actionable menu

Expected Result:

The Upgrade option is displayed after selecting the "Categorize it" option in the actionable menu in the account without workspaces

Actual Result:

Hmm... it's not here is displayed after selecting the "Categorize it" option in the account where all workspaces were deleted. The modal with the Upgrade option is displayed after selecting the "Clear cache and restart" option in Troubleshoot

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6707701_1736209708374.Recording__346.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876588733605475971
• Upwork Job ID: 1876588733605475971
• Last Price Increase: 2025-01-07
• Automatic offers:
• ZhenjaHorbach | Reviewer | 105628313
• mkzie2 | Contributor | 105628314

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2025-01-07 10:02:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm... it's not here is displayed after selecting the "Categorize it" option in the account where all workspaces were deleted. The modal with the Upgrade option is displayed after selecting the "Clear cache and restart" option in Troubleshoot

What is the root cause of that problem?

After we delete the default workspace, the activePolicy data still exists with three fields then we still go to the category page then the not found page appear based on AccessOrNotFoundWrapper

App/src/libs/ReportUtils.ts

Line 8353 in 96280b8

if (activePolicy && activePolicy?.type !== CONST.POLICY.TYPE.PERSONAL && activePolicy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {

What changes do you think we should make in order to solve the problem?

We should use shouldShow policy function to check whether the policy is valid or not. That has already covered the personal policy and pending delete case.

if (PolicyUtils.shouldShowPolicy(activePolicy, false, currentUserEmail)) {

App/src/libs/ReportUtils.ts

Line 8353 in 96280b8

if (activePolicy && activePolicy?.type !== CONST.POLICY.TYPE.PERSONAL && activePolicy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {

We also need to do the same here to filter out the invalid policy above

const filteredPolicies = Object.values(allPolicies ?? {}).filter(
    (policy) => PolicyUtils.shouldShowPolicy(policy, false, currentUserEmail),
);

App/src/libs/ReportUtils.ts

Line 8348 in 96280b8

(policy) => policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876588733605475971

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[twisterdotcom]

Recreated in Chrome too.

54864.mp4

[ZhenjaHorbach]

Yeah
Agree
This can easily be reproduced on the web also

@mkzie2
And thanks for your proposal !
The proposal makes sense to me and works well !

🎀👀🎀 C+ reviewed

Plus I also noticed that we also use the old logic in hasNoPolicyOtherThanPersonalType util that is not used anywhere else

App/src/libs/PolicyUtils.ts

Lines 1101 to 1106 in cf9a023

	function hasNoPolicyOtherThanPersonalType() {
	return (
	Object.values(allPolicies ?? {}).filter((policy) => policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE)
	.length === 0
	);
	}

So we can remove it as well

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.