[HOLD for payment 2025-02-05] [$250] Workspace expense report title updates when paid

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.80-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): #52596 (comment)

Action Performed:

1. Sign-up on new.expensify.com
2. Choose "Manage my team's expenses"
3. Create an expense on the workspace
4. Click into the expense report preview
5. Observe the report title "Expense Report #"
6. Click "pay elsewhere"
7. Observe the report title change.

Expected Result:

The report title shouldn't change on being paid.

Actual Result:

The report title changes:

Workaround:

N/A, UI bug.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Fresh repro:

2025-01-06_16-29-51.mp4

View all open jobs on GitHub

CC: @JmillsExpensify @thienlnam

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879229019409365796
• Upwork Job ID: 1879229019409365796
• Last Price Increase: 2025-01-14
• Automatic offers:
• mkzie2 | Contributor | 105795743

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-15 11:45:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace expense report title updates when paid

What is the root cause of that problem?

When the report is not settled reportFields are fetched using getReportFieldsByPolicyID(report?.policyID)
This method successfully retrieves the required fields, including REPORT_FIELD_TITLE_FIELD_ID

As soon as the report gets settled, the function attempts to fetch the reportFields from report.fieldList. However, report?.fieldList is undefined when the report fields are disabled.

What changes do you think we should make in order to solve the problem?

we should change

App/src/libs/ReportUtils.ts

Line 3242 in 7b9e55e

const reportFields = isReportSettled ? report?.fieldList : getReportFieldsByPolicyID(report?.policyID);

To fetch reportFields only from getReportFieldsByPolicyID(report?.policyID)

    const reportFields = getReportFieldsByPolicyID(report?.policyID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

N/A

[samranahm]

Hi @neil-marcellini, @adelekennedy please look at the proposal above when you have time and let me know if you want me to change anything.

[melvin-bot]

@neil-marcellini, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

@neil-marcellini for review - do you also need external support here from C+?