Skip to content

[Due for payment 2025-02-10] Revert #52569 #54054

Description

@JmillsExpensify

After giving the solution in #52569 a try, we've realized that it creates a confusing situation in the Inbox, which is:

  • Workspace chat is GBRed
  • Report has a grey Approved button

So in short, our solution for approve and pay (specifically with a report that has some held expenses and some unheld expenses) ends up breaking GBR.

As a result, we're going to revert the PR from #52569. That restores GBR to the Inbox and workspace chat. In addition, for the Search page specifically, we are going to disable the Approve button for this case, just like we landed on doing for Pay.

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions