[HOLD for payment 2025-01-15] [$250] IOS - Room description input field needs multiple taps before it gets focused

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): nathanmulugetatesting+2395@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open Expensify app
2. Create a workspace and a room
3. Open room and tap on header
4. Tap on Room description
5. Tap on room description input field to get it focused

Expected Result:

The room description page gets auto focused and when tapping manually to focus it it does it instantly

Actual Result:

Room description input field becomes unresponsive for a while until it gets focused after multiple taps

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6689986_1733835142249.Screenrecording_12-10-2024_15-47-48_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021868754548854947676
• Upwork Job ID: 1868754548854947676
• Last Price Increase: 2024-12-16
• Automatic offers:
• Krishna2323 | Contributor | 105401432

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-12-10 14:00:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Room description input field needs multiple taps before it gets focused

What is the root cause of that problem?

• The input is focused twice at the same time, due to which input is not focused correctly and it is causing this issue.
  

  App/src/pages/RoomDescriptionPage.tsx

  Lines 65 to 77 in 70b9238

  	useFocusEffect(
  	useCallback(() => {
  	focusTimeoutRef.current = setTimeout(() => {
  	reportDescriptionInputRef.current?.focus();
  	return () => {
  	if (!focusTimeoutRef.current) {
  	return;
  	}
  	clearTimeout(focusTimeoutRef.current);
  	};
  	}, CONST.ANIMATED_TRANSITION);
  	}, []),
  	);

  
  

  App/src/pages/RoomDescriptionPage.tsx

  Line 114 in 70b9238

  updateMultilineInputRange(el);

  
  

  App/src/libs/updateMultilineInputRange/index.ios.ts

  Lines 12 to 25 in 70b9238

  	const updateMultilineInputRange: UpdateMultilineInputRange = (input, shouldAutoFocus = true) => {
  	if (!input) {
  	return;
  	}
  	/*
  	* Adding this iOS specific patch because of the scroll issue in native iOS
  	* Issue: does not scroll multiline input when text exceeds the maximum number of lines
  	* For more details: https://github.com/Expensify/App/pull/27702#issuecomment-1728651132
  	*/
  	if (shouldAutoFocus) {
  	input.focus();
  	}
  	};

• The immediate focus was added to solve the scroll issue on IOS, but after applying the main solution the scroll behaviour works fine.

What changes do you think we should make in order to solve the problem?

1. Pass false as the second argument to updateMultilineInputRange.
2. We should also identify other similar components and apply the fix there if the same issue occurs.
3. Additionally, we can use useAutoFocusInput instead of using useFocusEffect with a timeout.
4. If I recall correctly, the same issue occurred in the PrivateNotesEditPage component. We will check all components, regardless.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


What alternative solutions did you explore? (Optional)

1. We can update useFocusEffect cb to not focus for ios devices instead of passing false to updateMultilineInputRange. We can use getPlatform for that.

Result

Monosnap.screencast.2024-12-10.19-42-37.mp4

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021868754548854947676

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)