[HOLD for payment 2025-01-15] [$250] Workspace - Default workspace currency is changed to USD when changing a workspace name

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.73-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+shsb22554212@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Prerequisite
User's location is not US and default currency is not USD

1. Sign in with a same account both in ND and OD
2. In OD create a new workspace which will automatically set a default currency which is not USD
3. Navigate to new dot > Workspace settings > Profile > Name > Edit the name of the workspace > Save
4. Now observe the default currency when saving the edited name

Expected Result:

Default currency stays the same when editing the name of the workspace

Actual Result:

Default currency is automatically changed to USD when editing the name of the workspace

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6689882_1733826538548.2024-12-10_13_23_39.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866457192804972214
• Upwork Job ID: 1866457192804972214
• Last Price Increase: 2024-12-24

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default currency is changed to USD if the policy is created from OD.

What is the root cause of that problem?

This has the same root cause as #52190. When we create a policy from OD and we view it in ND, the outputCurrency of the policy is not available yet. Updating the workspace name also requires a currency param and we fallback to USD.

App/src/libs/actions/Policy/Policy.ts

Line 1171 in 5a0c689

const currency = currencyValue ?? policy?.outputCurrency ?? CONST.CURRENCY.USD;

What changes do you think we should make in order to solve the problem?

Since the API requires the currency param too, we can follow the same approach in #53132 by fallback to other values first before fallback to USD.

const currency = currencyValue ?? policy?.outputCurrency ?? DistanceRequestUtils.getDefaultMileageRate(policy)?.currency ?? PolicyUtils.getPersonalPolicy()?.outputCurrency ?? CONST.CURRENCY.USD;

Or if we want a more complex approach, then the BE needs to update the API to accept undefined currency which indicates that we don't want to update the currency, so we don't need to fallback to USD and skip the currency optimistic data.

Or, BE can separate the UpdateWorkspaceGeneralSettings API into 2 APIs, 1 for name, 1 for currency.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can merge a fake policy without outputCurrency to Onyx but it has the mileage rate data which contains the currency information. Then, assert that after calling updateGeneralSettings without currency param, the policy currency data isn't changed.

[trjExpensify]

So strange, I can repro this.

2024-12-10_13-03-22.mp4

@MonilBhavsar as you worked on that change initially, can you take a look at this? If the user doesn't change the currency field, we don't want to update it to USD.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866457192804972214

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)