[HOLD for payment 2025-01-17] [$100] Distance rates - Tax reclaimable can be equal Tax rates

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3073283
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

Precondition: Distance rates and Taxes are enabled in workspace more features tab. Track tax is enabled in Distance rates settings.

1. Go to WS > Distance rates
2. Click on Default rate ($0,67 / mile)
3. Set Tax Rate
4. Click on Tax reclaimable on
5. Set value > Default rate (e.g. 0.68) > Save
6. Set value = Default rate (e.g. 0.67) > Save

Expected Result:

Step 5. An error appears 'The reclaimable portion must be less than the distance rate amount.'
Step 6. Value is not saved. Expect that 'The reclaimable portion must be less than the distance rate amount.' OR another error text. User can set 0.66 but not 0.67

Actual Result:

Step 6. Value is saved.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867265132758522754
• Upwork Job ID: 1867265132758522754
• Last Price Increase: 2024-12-12
• Automatic offers:
• FitseTLT | Contributor | 105312886

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-06 16:30:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates - Tax reclaimable can be equal Tax rates

What is the root cause of that problem?

We are only checking that taxClaimableValue is greater than the rate here

App/src/libs/PolicyDistanceRatesUtils.ts

Lines 50 to 51 in 48b80f6

	if (rate?.rate && Number(values.taxClaimableValue) > rate.rate / 100) {
	errors.taxClaimableValue = Localize.translateLocal('workspace.taxes.error.updateTaxClaimableFailureMessage');

What changes do you think we should make in order to solve the problem?

We should change the condition to >=

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a simple test for validateTaxClaimableValue and pass equal tax rate and taxClaimableValue and assert that correct errors.taxClaimableValue is returned from the function

What alternative solutions did you explore? (Optional)

If we want to allow tax reclaimable to be equal then we should update our updateTaxClaimableFailureMessage copy accordingly

[MonilBhavsar]

@muttmuure this an edge case and one liner change, could be tagged at $100

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867265132758522754

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)