[HOLD for payment 2024-11-20] [$250] Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Open the staging.new.expensify.com website.
2. Sign up with a new account.
3. Select "Manage my team´s expenses"
4. Complete the onboarding process selecting any option on the following steps.
5. Verify you land on Concierge chat and the conversation is auto scrolled to the bottom.

Expected Result:

When landing on Concierge chat, the conversation should be auto scrolled to the bottom.

Actual Result:

When selecting "Manage my team´s expenses" during onboarding process, Concierge chat is not auto scrolled to the bottom when the user is redirected to it.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6655025_1730778650817.Concierge.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853799179762467415
• Upwork Job ID: 1853799179762467415
• Last Price Increase: 2024-11-05
• Automatic offers:
• brunovjk | Reviewer | 104756320
• FitseTLT | Contributor | 104756322

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process

What is the root cause of that problem?

The root cause of the problem is we haven't provided lastVisibleActionCreated optimistically for the target chat Report here

App/src/libs/actions/Report.ts

Lines 3643 to 3651 in 210db71

	optimisticData.push(
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${targetChatReportID}`,
	value: {
	lastMentionedTime: DateUtils.getDBTime(),
	hasOutstandingChildTask,
	},
	},

What changes do you think we should make in order to solve the problem?

We need to set the lastVisibleActionCreated to last action added to the targetChatReportID optimistically
so we will set it to the last task report action timestamp and if it is not available we will set it to the video comment action otherwise to the text comment action's created timestamp.

    const lastVisibleActionCreated =
        tasksData.at(-1)?.completedTaskReportAction?.created ?? tasksData.at(-1)?.taskReportAction.reportAction.created ?? videoCommentAction?.created ?? textCommentAction.created;

    const optimisticData: OnyxUpdate[] = [...tasksForOptimisticData];
    optimisticData.push(
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${targetChatReportID}`,
            value: {
                lastMentionedTime: DateUtils.getDBTime(),
                hasOutstandingChildTask,
                lastVisibleActionCreated,
            },
        },       

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021853799179762467415

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[twisterdotcom]

Possibly linked: #49599

[FitseTLT]

Possibly linked: #49599

Nope, that is completely different issue. 👍

[luckydaniel1993]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Sign Up - Concierge chat is not auto scrolled to the bottom after onboarding process

What is the root cause of that problem?

After completing the onboard flow, we didn't notify that is a new action.

What changes do you think we should make in order to solve the problem?

At the end of completeOnboarding function (after API.write), I added notifyNewAction.
notifyNewAction(targetChatReportID, currentUserAccountID);

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: anasup1995@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!