[HOLD for payment 2024-11-20] [$250] Expense-"Hidden" appears in Members list when the workspace is created via Pay with Expensify

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5134693
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Default individual policy currency for both users must be USD.

1. Go to staging.new.expensify.com
2. [User A] Submit an expense in USD to User B
3. [User B] Go to DM with user A
   4/ [User B] Click Pay with Expensify
4. [User B] Click Business bank account
5. [User B] Close the RHP
6. [User B] Go to workspace settings of the newly created workspace
7. [User B] Go to Members

Expected Result:

There will be no "Hidden" member

Actual Result:

"Hidden" member appears in Members list when the workspace is created via Pay with Expensify in p2p expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6645865_1729878847118.20241026_014655.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853396876299534935
• Upwork Job ID: 1853396876299534935
• Last Price Increase: 2024-11-04

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is shown in the workspace member after moving the expense to a new workspace.

What is the root cause of that problem?

When we select Business bank account as the payment method, we will optimistically create a new workspace based on the IOU report data.

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 110 to 111 in 652d2ff

	if (iouReport && ReportUtils.isIOUReport(iouReport)) {
	const {policyID, workspaceChatReportID, reportPreviewReportActionID} = Policy.createWorkspaceFromIOUPayment(iouReport) ?? {};

The problem is, we are trying to create the workspace member from the IOU report ownerEmail.

App/src/libs/actions/Policy/Policy.ts

Line 2134 in 652d2ff

const employeeEmail = iouReport.ownerEmail ?? '';

App/src/libs/actions/Policy/Policy.ts

Lines 2184 to 2191 in 652d2ff

	[sessionEmail]: {
	role: CONST.POLICY.ROLE.ADMIN,
	errors: {},
	},
	[employeeEmail]: {
	role: CONST.POLICY.ROLE.USER,
	errors: {},
	},

However, ownerEmail doesn't exist anymore in the IOU report, only ownerAccountID, so it defaults to an empty string.

What changes do you think we should make in order to solve the problem?

There was previously a plan to get the employee email from the personal detail, but I decided to just default it to an empty string because, at that time, the email wasn't really needed.

Previously, the policy member is keyed by their accountID.

So, the solution is to get the employee's email from the personal details data.

const employeeEmail = allPersonalDetails?.[employeeAccountID]?.login ?? '';

I don't think the personal detail login would be undefined, but we can avoid creating the employee optimistic data if employeeEmail is empty.

[zanyrenney]

Wave collect is closed, but adding this to expense.

[melvin-bot]

@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[zanyrenney]

Oops, i thought I added the external label here - my bad!