[HOLD for payment 2024-11-11] [HOLD for payment 2024-11-05] [$250] De-dupe AddComment, EditComment, and DeleteComment requests

[roryabraham]

Problem

When we make unnecessary network requests, it slows down the app and contributes to higher traffic on our servers. In particular:

• if you are offline and you serialize multiple EditComment requests, only the last one will take effect
• if you serialize both an AddComment and any number of EditComment requests, the result would be the same as one AddComment with the content of the final EditComment
• if you serialize an AddComment followed by a DeleteComment, the end result is the same as not sending any network requests at all
• if you serialize an EditComment request followed by a DeleteComment, the end result is the same as only sending the DeleteComment

Solution

De-dupe the network requests!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848400026446902359
• Upwork Job ID: 1848400026446902359
• Last Price Increase: 2024-10-21
• Automatic offers:
• dukenv0307 | Reviewer | 104528746
• c3024 | Contributor | 104528756

Issue Owner

Current Issue Owner: @bfitzexpensify

[roryabraham]

cc @gedu

[gedu]

Hey, I'm Edu from Callstack, I can take this one

[shubham1206agra]

There are several obstacles to achieve this.

1. if you are offline and you serialize multiple EditComment requests, only the last one will take effect

The obstacle here is that if the request fails after replace call, it will show wrong comment.

2. if you serialize an AddComment followed by a DeleteComment, the end result is the same as not sending any network requests at all

This is tricky as we are now reducing the queue size.

[roryabraham]

The obstacle here is that if the request fails after replace call, it will show wrong comment.

isn't that the case today with any EditComment request? Or is there something I'm missing?

[roryabraham]

Going on parental leave. @gedu @mountiny @shubham1206agra I leave this in your capable hands. My parting note is to please use as many automated tests to cover this change as possible 👍🏼

[gedu]

I just made a PR for OpenApp, I will start taking a look at this