[HOLD for payment 2024-10-16] [$250] Desktop - Bank account - Modal appears to open the page in the app when I was redirected from the app

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4992364&group_by=cases:section_id&group_order=asc&group_id=283225
Issue reported by: Applause Internal Team

Action Performed:

1. Open the app
2. Log in with a new Expensifail account
3. Create a workspace
4. Navigate to Workspace settings - More features
5. Enable "Workflows"
6. Navigate to Workflows - Connect bank account
7. Click on the note to open the process in a browser

Expected Result:

The modal shouldn't appear.

Actual Result:

Modal appears to open the page in the app when I was redirected from the app.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6610075_1726848075157.Screen_Recording_2024-09-20_At_8.50.37.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841531184818757029
• Upwork Job ID: 1841531184818757029
• Last Price Increase: 2024-10-02

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The prompt to open on the desktop shows after redirected from the desktop app.

What is the root cause of that problem?

When we redirected from the desktop to the web app, the logic to prompt the user to open on the desktop will be executed. There is currently no logic to prevent it from showing if the user comes from the desktop app.

App/src/components/DeeplinkWrapper/index.website.tsx

Lines 19 to 32 in 4c76858

	function promptToOpenInDesktopApp(initialUrl = '') {
	// If the current url path is /transition..., meaning it was opened from oldDot, during this transition period:
	// 1. The user session may not exist, because sign-in has not been completed yet.
	// 2. There may be non-idempotent operations (e.g. create a new workspace), which obviously should not be executed again in the desktop app.
	// So we need to wait until after sign-in and navigation are complete before starting the deeplink redirect.
	if (Str.startsWith(window.location.pathname, Str.normalizeUrl(ROUTES.TRANSITION_BETWEEN_APPS))) {
	App.beginDeepLinkRedirectAfterTransition();
	} else {
	// Match any magic link (/v/<account id>/<6 digit code>)
	const isMagicLink = CONST.REGEX.ROUTES.VALIDATE_LOGIN.test(window.location.pathname);
	App.beginDeepLinkRedirect(!isMagicLink, Link.getInternalNewExpensifyPath(initialUrl));
	}
	}

What changes do you think we should make in order to solve the problem?

1. To know if the user is coming from the desktop, we can add a new param to the URL called referrer with a value of desktop.
   

   App/src/libs/actions/Link.ts

   Lines 193 to 202 in 4c76858

   	function buildURLWithAuthToken(url: string, shortLivedAuthToken?: string) {
   	const authTokenParam = shortLivedAuthToken ? `shortLivedAuthToken=${shortLivedAuthToken}` : '';
   	const emailParam = `email=${encodeURIComponent(currentUserEmail)}`;
   	const exitTo = `exitTo=${url}`;
   	const accountID = `accountID=${currentUserAccountID}`;
   	const paramsArray = [accountID, emailParam, authTokenParam, exitTo];
   	const params = paramsArray.filter(Boolean).join('&');
   	return `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}transition?${params}`;
   	}

const referrer = 'referrer=desktop';
const paramsArray = [accountID, emailParam, authTokenParam, exitTo, referrer];

buildURLWithAuthToken is currently only being used for redirecting the user from desktop to web, so we can always set the value to desktop for now.

2. Don't prompt the user if the URL params referrer is desktop.
   

   App/src/components/DeeplinkWrapper/index.website.tsx

   Lines 24 to 26 in 4c76858

   	if (Str.startsWith(window.location.pathname, Str.normalizeUrl(ROUTES.TRANSITION_BETWEEN_APPS))) {
   	App.beginDeepLinkRedirectAfterTransition();
   	} else {

if (Str.startsWith(window.location.pathname, Str.normalizeUrl(ROUTES.TRANSITION_BETWEEN_APPS))) {
    const params = new URLSearchParams(window.location.search);
    if (params.get('referrer') === 'desktop') {
        return;
    }
    App.beginDeepLinkRedirectAfterTransition();
} else ...

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841531184818757029

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)