[HOLD for payment 2024-10-24] [$125] QBO Desktop - The message is incorrectly formatted after a failed connection

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validation PR: #48759
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. ND: Navigate to https://staging.new.expensify.com/
2. ND: Log in with a new Gmail account
3. ND: Create a workspace
4. ND: Navigate to OD by clicking on Account settings - Domains
5. OD: Navigate to Settings - Workspaces - "Created workspace name" - Connections
6. OD: Upgrade the WS to Collect with the lock icon next to "QuickBooks Desktop"
7. OD: Click on QuickBooks Desktop - Connect to QuickBooks Desktop - Connect to QuickBooks Desktop
8. OD: Attempt to connect to QuickBooks Desktop (the connection will fail)
9. ND: Navigate to the #admins room

Expected Result:

The message should be "Failed to sync with QuickBooks Desktop"

Actual Result:

The message is incorrectly formatted after a failed connection.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.2826.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838585551890315008
• Upwork Job ID: 1838585551890315008
• Last Price Increase: 2024-10-01

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The message is incorrectly formatted after a failed connection.

What is the root cause of that problem?

The label is not correct and errorMessage is missing from the integration sync failed report action:

App/src/pages/home/report/ReportActionItem.tsx

Lines 684 to 686 in 837e413

	} else if (ReportActionsUtils.isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.INTEGRATION_SYNC_FAILED)) {
	const {label, errorMessage} = ReportActionsUtils.getOriginalMessage(action) ?? {label: '', errorMessage: ''};
	children = <ReportActionItemBasicMessage message={translate('report.actions.type.integrationSyncFailed', label, errorMessage)} />;

What changes do you think we should make in order to solve the problem?

For the label, I think it's an BE problem not to format quickbooksDesktop properly.

For the errorMessage, we should only show the message part ("${errorMessage}") when we have the message content:

App/src/languages/en.ts

Line 4199 in d13f37b

integrationSyncFailed: (label: string, errorMessage: string) => `failed to sync with ${label} ("${errorMessage}")`,

`failed to sync with ${label}${errorMessage? `("${errorMessage}")` : ''}`

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838585551890315008

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)