Tags - Custom name for state can be saved as 0

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4923046
Issue reported by: Applause Internal Team

Action Performed:

1. Go to old dot site
2. Tap settings-- workspace -- tags
3. Select people must tag expense & multiple level tags
4. Uncheck independent tags
5. Upload dependent tags given below
6. Go to new dot site
7. Open workspace -- tags
8. Change custom name for "state" as "0" and save
9. Note no error displayed
10. Change custom name for "region" as "0" and save

Expected Result:

Custom name for tags must not be allowed to save as 0.

Actual Result:

Custom name for state can be saved as 0 but for region error shown.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592546_1725430384155.voi.mp4

Bug6592546_1725430384156!Dependent_-_Multi_Level_tags_NEW.csv

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

@VictoriaExpensify We can put this on hold in favour of this #48300

[eucool]

Edited by proposal-police: This proposal was edited at 2023-10-05T13:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Allowed to save custom Tag name as 0.

What is the root cause of that problem?



We do not have any validation in place to check for custom tag name here, this is why we do not get any validation errors here




What changes do you think we should make in order to solve the problem?

Like we do for regular tag names, we can add a validation for custom tag names as well:

App/src/pages/workspace/tags/EditTagPage.tsx

Lines 48 to 49 in f890c73

	} else if (escapedTagName === '0') {
	errors.tagName = translate('workspace.tags.invalidTagNameError');

So we have to update the code here to:

const validateTagName = useCallback(
        (values: FormOnyxValues<typeof ONYXKEYS.FORMS.POLICY_TAG_NAME_FORM>) => {
            const errors: FormInputErrors<typeof ONYXKEYS.FORMS.POLICY_TAG_NAME_FORM> = {};
            .
            .
            if (values[INPUT_IDS.POLICY_TAGS_NAME].trim() === '0'){
              errors[INPUT_IDS.POLICY_TAGS_NAME] = translate('workspace.tags.invalidTagNameError');
            }
            
           .
           .
           .
            return errors;
        },
        [translate, policyTags, route.params.orderWeight],
    );

We can look at any other parts of the code where these changes are needed and also small improvements can be done during PR phase

What alternative solutions did you explore? (Optional)

[VictoriaExpensify]

Like @Nodebrute mentioned, there are a number of other issues raised in relation to this - all tag 0 issues are being consolidated here - #48300

I don't think we need to put this on hold, it can be closed out.