[$250] Tags - Existing tags are restructured when custom tag name is 0 and adding 0: 0 as tag

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.26-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4902717
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Add a few tags.
4. Click Settings > Custom tag name.
5. Enter 0 as custom tag name.
6. Add 0: 0 as tag.

Expected Result:

Nothing will happen to the existing tags.

Actual Result:

The existing tags are duplicated and restructured - one set falls under 0: 0 as multi tags, the other set is regular tag.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6586729_1724944970596.20240829_231756.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831485723893012269
• Upwork Job ID: 1831485723893012269
• Last Price Increase: 2024-09-05

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-08-29 21:30:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Existing tags are restructured when custom tag name is 0 and adding 0: 0 as tag

What is the root cause of that problem?

We don't check when user add 0 as a custom tag name. It's a similar issue to this #45016. The backend response is null

key
: 
"policyTags_8FE3CA458B14BEF9"
onyxMethod
: 
"merge"
value
: 
[null]
0
: 
null

What changes do you think we should make in order to solve the problem?

We should stop user from adding 0 as a custom tag name. We can go for similar approach that we do here

App/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx

Line 48 in 8c0386a

} else if (tagName === '0') {

We can throw error when user tries to enter 0 in custom tag. We can also add translations in en.ts and es.ts files for the error.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!