[HOLD for payment 2024-10-16] [$500] Distance rates - Enabled distance rate changes to "Disabled" after deleting it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4902934
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Go to Categories
4. Disable an active (enabled) category
5. Note that the disabled category that was previously enabled shows "Enabled" in strikethrough style
6. Go to Distance rates
7. Disable an active (enabled) distance rate

Expected Result:

The distance rate status should remain "Enabled" in strikethrough style, which is the behavior for categories and tags

Actual Result:

The distance rate status changes to "Disabled" after deleting the rate offline, which is inconsistent with category and tag behavior

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6586441_1724930004395.20240829_190821.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0103dd03b250392922
• Upwork Job ID: 1829237965961527437
• Last Price Increase: 2024-09-10
• Automatic offers:
• paultsimura | Contributor | 103803832
• Krishna2323 | Contributor | 103803839

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

I think this is expected as per #45146.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enabled distance rate changes to "Disabled" after deleting it

What is the root cause of that problem?

We are setting enabled to false here

App/src/libs/actions/Policy/DistanceRate.ts

Line 492 in e054a71

enabled: false,

What changes do you think we should make in order to solve the problem?

Remove this line from here

App/src/libs/actions/Policy/DistanceRate.ts

Line 492 in e054a71

enabled: false,

This will make it consistent with categories, tags, and taxes.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0103dd03b250392922

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[FitseTLT]

This is intentional #45146 Tagging @paultsimura

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-29 19:23:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates - Enabled distance rate changes to "Disabled" after deleting it

What is the root cause of that problem?

The rate is disabled when deleted.

App/src/libs/actions/Policy/DistanceRate.ts

Line 492 in e054a71

enabled: false,

What changes do you think we should make in order to solve the problem?

1. We need to remove the enabled: false,
2. In getMileageRates, we also need to include the pending action.
   

   App/src/libs/DistanceRequestUtils.ts

   Line 35 in e054a71

   function getMileageRates(policy: OnyxInputOrEntry<Policy>, includeDisabledRates = false): Record<string, MileageRate> {

3. In IOURequestStepDistanceRate, we need to filter out the rates with pending action delete. Or we can use the isDisabled property.
   

   App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

   Lines 72 to 82 in e054a71

   	const sections = Object.values(rates).map((rate) => {
   	const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit);
   	return {
   	text: rate.name ?? rateForDisplay,
   	alternateText: rate.name ? rateForDisplay : '',
   	keyForList: rate.customUnitRateID,
   	value: rate.customUnitRateID,
   	isSelected: currentRateID ? currentRateID === rate.customUnitRateID : rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE,
   	};
   	});

4. We should also look for other uses of the distance rates in other component and filter out the deleted rates if needed.

What alternative solutions did you explore? (Optional)



If we also need to grey out the option when updated offline, we nee to also return pendingFields from getMileageRates and update the pendingAction property like we do in PolicyDistanceRatesPage.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 113 to 118 in 68374a5

	pendingAction:
	value.pendingAction ??
	value.pendingFields?.rate ??
	value.pendingFields?.enabled ??
	value.pendingFields?.currency ??
	(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

    const sections = Object.values(rates).map((rate) => {
        const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit);

        return {
         text: rate.name ?? rateForDisplay, 
         alternateText: rate.name ? rateForDisplay : '', 
         keyForList: rate.customUnitRateID, 
         value: rate.customUnitRateID, 
         isSelected: currentRateID ? currentRateID === rate.customUnitRateID : rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE, 
        pendingAction:
        rate.pendingAction ??
        rate.pendingFields?.rate ??
        rate.pendingFields?.enabled ??
        rate.pendingFields?.currency ??
        rate.pendingFields?.taxRateExternalID ??
        rate.pendingFields?.taxClaimablePercentage ??
        (policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),
        };
    });

What alternative solutions did you explore? (Optional 2)


If we want to disable category, tag, taxes when they are deleted then we can:

1. Update enabled property in all the delete util functions for category, tag, taxes.
   

   App/src/libs/actions/Policy/Tag.ts

   Line 301 in 9275b86

   acc[tagName] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE};

   
   

   App/src/libs/actions/TaxRate.ts

   Line 307 in 9275b86

   acc[taxID] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, errors: null};

   
   

   App/src/libs/actions/Policy/Category.ts

   Line 544 in 9275b86

   acc[categoryName] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE};

Result

[Krishna2323]

@brunovjk, I think this is not intentional because the PR tried to solve a different issue but introduced this bug, the PR was focused on not showing the deleted distance rates in the IOU request flow.