[$250] Expense - Currently opened report disappears from LHN after DM report throws error

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4900394
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User A and B have never chatted before.

1. Go to staging.new.expensify.com
2. [User A] Go offline.
3. [User A] Submit an expense to User B.
4. [User B] While online, submit an expense to User A.
5. [User A] While on DM with User B, go online.

Expected Result:

After the error appears for User A, the currently opened report (DM with error) will be shown and highlighted in LHN.

Actual Result:

After the error appears for User A, the currently opened report (DM with error) disappears from LHN.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6586275_1724922714676.20240829_170745.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831333278248310573
• Upwork Job ID: 1831333278248310573
• Last Price Increase: 2024-10-09

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A report with an error because there is an existing report disappears from the LHN.

What is the root cause of that problem?

Once we receive the error, the report has a errorFields.notFound data. Based on this condition, if the report has a not found error, then it won't be shown on the LHN.

App/src/libs/ReportUtils.ts

Lines 5942 to 5944 in b188243

	if (!canAccessReport(report, policies, betas)) {
	return false;
	}

App/src/libs/ReportUtils.ts

Lines 5769 to 5777 in b188243

	function canAccessReport(report: OnyxEntry<Report>, policies: OnyxCollection<Policy>, betas: OnyxEntry<Beta[]>): boolean {
	// We hide default rooms (it's basically just domain rooms now) from people who aren't on the defaultRooms beta.
	if (isDefaultRoom(report) && !canSeeDefaultRoom(report, policies, betas)) {
	return false;
	}
	if (report?.errorFields?.notFound) {
	return false;
	}

But previously, we always included the report even if the error is a not found error, but we updated it by adding isReportInAccessible condition in #47340.

App/src/libs/SidebarUtils.ts

Lines 116 to 130 in b188243

	const hasErrorsOtherThanFailedReceipt =
	doesTransactionThreadReportHasViolations ||
	doesReportHaveViolations ||
	Object.values(allReportErrors).some((error) => error?.[0] !== Localize.translateLocal('iou.error.genericSmartscanFailureMessage'));
	const isReportInAccessible = report?.errorFields?.notFound;
	if (ReportUtils.isOneTransactionThread(report.reportID, report.parentReportID ?? '0', parentReportAction)) {
	return;
	}
	if (hasErrorsOtherThanFailedReceipt && !isReportInAccessible) {
	reportsToDisplay.push({
	...report,
	hasErrorsOtherThanFailedReceipt: true,
	});
	return;
	}

What changes do you think we should make in order to solve the problem?

We can follow the condition from the report screen to hide the LHN by only hide it if the report error is only not found.

App/src/pages/home/ReportScreen.tsx

Lines 297 to 298 in b188243

	const hasHelpfulErrors = Object.keys(report?.errorFields ?? {}).some((key) => key !== 'notFound');
	const shouldHideReport = !hasHelpfulErrors && !ReportUtils.canAccessReport(report, policies, betas);

App/src/libs/ReportUtils.ts

Lines 5942 to 5944 in b188243

	if (!canAccessReport(report, policies, betas)) {
	return false;
	}

const hasHelpfulErrors = Object.keys(report?.errorFields ?? {}).some((key) => key !== 'notFound');
if (!hasHelpfulErrors && !canAccessReport(report, policies, betas)) {
    return false;
}

In our case, we have createChat and notFound error, so it will be shown on the LHN.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831333278248310573

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)