[Hold for payment 2024-08-27][$250] Missing checkmark when reselecting date of month in Submission frequency modal

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.20-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723741251007689

Action Performed:

1. Open app
2. Open a workspace with enable workflow
3. Turn on Delay submissions and open Submission frequency
4. Choose monthly
5. Choose Date of month
6. Select any date
7. Choose Date of month again

Expected Result:

The selected date is still focused and has a checkmark.

Actual Result:

The selected date is missing a checkmark on the right.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-08-16.at.00.01.29.mov

Recording.447.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0101f6414948e6716e
• Upwork Job ID: 1824158740168423243
• Last Price Increase: 2024-08-15
• Automatic offers:
• dukenv0307 | Reviewer | 103555137
• Krishna2323 | Contributor | 103555139

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected date is missing a checkmark on the right.

What is the root cause of that problem?

Currently, we are saving autoReportingOffset as string in Onyx and we are calculator isSelected by comparing day which is a number with offsetwhich is a string here

App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Line 46 in 9812479

isSelected: day === offset,

What changes do you think we should make in order to solve the problem?

We should convert offset to number here

            text: toLocaleOrdinal(day),
            keyForList: day.toString(), // we have to cast it as string for <ListItem> to work
+           isSelected: day === Number(offset),
            isNumber: true,

What alternative solutions did you explore? (Optional)

[dukenv0307]

@lschurr I'm reporter so I can take this bug as C+

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-15 18:53:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing checkmark when reselecting date of month in Submission frequency modal

What is the root cause of that problem?

We are using unnecessarily using toString() when passing the autoReportingOffset value to the backend.

App/src/libs/actions/Policy/Policy.ts

Line 453 in a07cce4

const value = JSON.stringify({autoReportingOffset: autoReportingOffset.toString()});

What changes do you think we should make in order to solve the problem?

We should remove the the toString() method. I have checked the backend response and it does support both number and string. Also OpenPolicyWorkflowsPage api call also returns autoReportingOffset as number.

We should also update value type in SetWorkspaceAutoReportingMonthlyOffsetParams.

App/src/libs/API/parameters/SetWorkspaceAutoReportingMonthlyOffsetParams.ts

Lines 1 to 4 in a07cce4

	type SetWorkspaceAutoReportingMonthlyOffsetParams = {
	policyID: string;
	value: string;
	};

What alternative solutions did you explore? (Optional)

We should also pass shouldUpdateFocusedIndex to SelectionList because the focus index in not changed when selecting monthly option and the RHP is not closed. We have an open issue for this, so I believe its better to handle both bugs separately.

[Krishna2323]

Proposal Updated

• Added alternative to fix another issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0101f6414948e6716e

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Checkmark missing when reselecting date in Submission Frequency modal.

What is the root cause of that problem?

This comparison has might have different type

App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Line 46 in 5a55cd5

isSelected: day === offset,

What changes do you think we should make in order to solve the problem?

If we check the AutoReportingOffset type it can contain number or string

App/src/types/onyx/Policy.ts

Line 1251 in 5a55cd5

type AutoReportingOffset = number | ValueOf<typeof CONST.POLICY.AUTO_REPORTING_OFFSET>;

We can use == instead of === to compare.

Using == instead of === will perform type coercion, which means it will convert the operands to the same type before making the comparison.

What alternative solutions did you explore? (Optional)

convert both to string for isSelected check.

src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

....
     const dayString = day.toString();
     const offsetString = offset.toString();

        return {
            text: toLocaleOrdinal(day),
            keyForList: dayString, // we have to cast it as string for <ListItem> to work
            isSelected: dayString === offsetString,
            isNumber: true,
        };