[HOLD for payment 2024-08-29] [$250] Track expense - Members count is 2 but there is nobody in the Members list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM
3. Click + > Track expense > Manual
4. Submit a track manual expense
5. Go to transaction thread
6. Click on the header
7. Click Members

Expected Result:

There should be only 1 member which is the self DM user, or there should not be Members tab because there is no active user in the transaction thread (no user comment)

Actual Result:

Members count is 2 but there is nobody in the Members list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6570301_1723493001902.20240813_040032.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01edf4005f4d3b65e9
• Upwork Job ID: 1824589766430408792
• Last Price Increase: 2024-08-16
• Automatic offers:
• akinwale | Reviewer | 103584364
• BhuvaneshPatil | Contributor | 103584366

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Members count is 2 but there is nobody in the Members list

What is the root cause of that problem?

In case of track expense we get participantIds from getParticipantsAccountIDsForDisplay().

in getParticipantsAccountIDsForDisplay(), we get values for participants using -

let participantsEntries = Object.entries(report?.participants ?? {});

that also return these two values, which doesn't look like a valid participant

And these values result in [NaN, NaN] as participantIDs array value that we return.

And where we show the count of members, we are checking length of this above mentioned array. Hence we get 2 as members count.

What changes do you think we should make in order to solve the problem?

• We can add filter for checking NaN value, There are multiple places where we can add this filter ->

1. In getParticipantsAccountIDsForDisplay(), before we return the final value.
2. If we want to scope this bug to , we can add filter at

const participants = useMemo(() => {
        const shouldExcludeHiddenParticipants = !isGroupChat && !isSystemChat;
        return ReportUtils.getParticipantsAccountIDsForDisplay(report, shouldExcludeHiddenParticipants);
    }, [report, isGroupChat, isSystemChat]);

Screen.Recording.2024-08-13.at.7.20.31.AM.mov

What alternative solutions did you explore? (Optional)

[BhuvaneshPatil]

@twisterdotcom Are we planning to make it external?

[melvin-bot]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Yes, I simply didn't get around to testing this, but I have now: https://github.com/user-attachments/assets/e2976749-82f5-414f-b5a1-2d0fbc2b0efa

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01edf4005f4d3b65e9