[HOLD for payment 2024-08-27][$250] [P2P Distance] - Unable to dismiss error "The selected rate has been deleted" in the expense report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace has some distance rates

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit a distance expense with a distance rate
4. Submit one more expense (any) if there is only one expense in the workspace chat
5. Go to workspace settings > Distance rates
6. Delete the distance rate used in Step 3
7. Go back to transaction thread (distance expense in Step 3)
8. Click Distance
9. Update distance by swapping position and save it
10. Click on the report header subtitle to go to expense report
11. Dismiss the error "The selected rate has been deleted"

Expected Result:

The error "The selected rate has been deleted" in the expense report will be dismissed

Actual Result:

Nothing happens after clicking on the X button next to the error "The selected rate has been deleted" in the expense report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6570216_1723487647032.20240813_022904.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f33a1dc5c2b867f0
• Upwork Job ID: 1823384515460729955
• Last Price Increase: 2024-08-13

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to close distance request transaction route errors.

What is the root cause of that problem?

We display invalid waypoint error message for an invalid distance request route under the report action item here:

App/src/pages/home/report/ReportActionItem.tsx

Line 945 in f80d19b

errors={linkedTransactionRouteError ?? ErrorUtils.getLatestErrorMessageField(action as ErrorUtils.OnyxDataWithErrors)}

But we only clear the report action error when press close:

App/src/pages/home/report/ReportActionItem.tsx

Line 939 in f80d19b

onClose={() => ReportActions.clearAllRelatedReportActionErrors(report.reportID, action)}

While we should do it for the transaction errors as well.

What changes do you think we should make in order to solve the problem?

1. Get the transactionID following:

App/src/pages/home/report/ReportActionItem.tsx

Line 1003 in f80d19b

`${ONYXKEYS.COLLECTION.TRANSACTION}${ReportActionsUtils.isMoneyRequestAction(action) ? ReportActionsUtils.getOriginalMessage(action)?.IOUTransactionID ?? -1 : -1}`,

2. And delete the transaction errors using Transaction.clearError

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f33a1dc5c2b867f0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to dismiss error "The selected rate has been deleted" in the expense report

What is the root cause of that problem?

We don't clear transactionErrors when we press x

What changes do you think we should make in order to solve the problem?

First we need to also clear transaction errors by adding Transaction.clearErrors when we press close here just like we are clearing errors in MoneyRequestView onClose

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 482 in 91e492c

Transaction.clearError(transaction?.transactionID ?? linkedTransactionID);

Note that after pressing the cross, the error disappears, but we can still see the RBR in the LHN and moneyPreview. When we open the report, there is no indication of the source of the error. The issue is due to an error in the rates field, which only resolves when a valid rate is selected. This error arises from a customUnitViolation, so we need to add logic to display the RBR in the rate field.

Screen.Recording.2024-08-13.at.9.04.53.PM.mov

We can get errors for customUnitRateID here

 brickRoadIndicator={getErrorForField('customUnitRateID') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
                    errorText={getErrorForField('customUnitRateID')}

We also need to change the following code from merchant to customUnitRateID because it is a rate violation

App/src/hooks/useViolations.ts

Line 20 in b6a0b56

customUnitOutOfPolicy: 'merchant',

Screen.Recording.2024-08-13.at.9.14.12.PM.mov

What alternative solutions did you explore? (Optional)

[ntdiary]

I think using Transaction.clearError to clear the rate error is feasible, we can move forward with @daledah's proposal. As for customUnitOutOfPolicy problem, issue #46753 and pr #47136 are addressing it. :)

🎀 👀 🎀 C+ reviewed