[HOLD FOR PAYMENT 8-27-2024] [$250] Duplicate Review - Description selector is not displayed when reviewing duplicates

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.18-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3106469

Issue reported by: Applause - Internal team
Slack conversation: N/A

Action Performed:

1. Navigate to a workspace chat
2. Create 2 duplicate expenses each with a different description
3. Navigate to one of the duplicates
4. Click on Review Duplicate
5. Click on "keep this one" on any

Expected Result:

The description selector should display for the user to select which description to keep

Actual Result:

Final confirmation is displayed in the review duplicates flow

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

duplicate.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179eedf51d4e3a1bd
• Upwork Job ID: 1821950383873413098
• Last Price Increase: 2024-08-09
• Automatic offers:
• c3024 | Reviewer | 103528468
• dominictb | Contributor | 103528469

Issue Owner

Current Issue Owner: @nkuoch

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Final confirmation is displayed in the review duplicates flow

What is the root cause of that problem?

We don't not add the description field to change if the description is not empty:

App/src/libs/TransactionUtils/index.ts

Line 980 in bd70f28

if (allCommentsAreEqual || allCommentsExist || allCommentsAreEmpty) {

What changes do you think we should make in order to solve the problem?

We can remove allCommentsExist.

[trjExpensify]

CC: @pecanoro @kubabutkiewicz for vis!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0179eedf51d4e3a1bd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[JmillsExpensify]

@c3024 thoughts on the proposals so far?