[HOLD for payment 2024-12-12] [$125] Web - Search - Filters - Extra margin below Save button in Category filter

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com

Action Performed:

1. Go to staging.new.expensify.com/search/filters
2. Click Category.

Expected Result:

There will be no extra margin below the Save button (production behavior).

Actual Result:

There is extra margin below the Save button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6565196_1723085486947.20240808_104712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f06d1723cda4320
• Upwork Job ID: 1821488943174214137
• Last Price Increase: 2024-08-08
• Automatic offers:
• dominictb | Contributor | 103505005

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Search - Filters - Extra margin below Save button in Category filter

What is the root cause of that problem?

Extra padding bottom is applied. When we pass footer component them it is wrapped with FixedFooter which already applies the margin for the footerContent.

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 138 in 53eee53

<View style={[styles.flex1, styles.pb5]}>

What changes do you think we should make in order to solve the problem?

Remove styles.pb5.

We should also remove includeSafeAreaPaddingBottom={false} if needed, the default is true so we can remove that.

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 129 in 53eee53

includeSafeAreaPaddingBottom={false}

What alternative solutions did you explore? (Optional)

We can use the confirm button in SelectionList and the we can remove footer content from SearchFiltersCategoryPage.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 726 to 738 in 53eee53

	{showConfirmButton && (
	<FixedFooter style={[styles.mtAuto]}>
	<Button
	success
	large
	style={[styles.w100]}
	text={confirmButtonText || translate('common.confirm')}
	onPress={onConfirm}
	pressOnEnter
	enterKeyEventListenerPriority={1}
	/>
	</FixedFooter>
	)}

We need to pass the following props:

                        showConfirmButton
                        confirmButtonText={translate('common.save')}
                        onConfirm={handleConfirmSelection}