[Awaiting Payment] [$250] [QBO Export] #admins QBO sync error message displays as a report export error

[arosiclair]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @arosiclair
Slack conversation: N/A

Action Performed:

Prerequisites

• Collect workspace with an admin and member
• Setup QBO integration connection

Steps

1. Log into QBO and disconnect the Expensify app (Menu > Apps > Overview > Expensify 3-dot menu > Disconnect)
2. Log into NewDot as the admin
3. Avatar > Workspaces > {QBO workspace} > Accounting > QBO > 3-dot menu > Sync Now
4. View #admins room for the workspce

Expected Result:

A message is posted notifying about a sync failure

Actual Result:

A message is posted about an export failure

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

This was a side effect of #42923. We're displaying all INTEGRATIONSMESSAGE actions using copy for report export errors, but these actions should be generic and are used for both export and sync errors.

We'll need to fix this either by just rendering the message straight from the DB (English only) or adding new specific action types for export and sync errors. I'll start a discussion about it before moving forward.

[arosiclair]

We'll need to fix this either by just rendering the message straight from the DB (English only)

Actually on further investigation, the message posted to the DB is also formatted as an export error so this won't work. So adding a new type of action for sync failures looks to be the only option. Posted a proposal here.

[arosiclair]

Alright we'll be moving forward with the proposal

Add a new INTEGRATIONSYNCFAILED action instead that displays the error with the correct copy. For now, it'll only be used to post sync errors to the #admins room and wouldn't appear anywhere in OldDot.

[melvin-bot]

@arosiclair, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@arosiclair, @muttmuure Huh... This is 4 days overdue. Who can take care of this?