[$250][P2P Distance] - Amount field is not grayed out when changing distance rate offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #40021
Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace has a few distance rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a distance expense.
4. Go to transaction thread.
5. Go offline.
6. Click Rate.
7. Select a different rate.

Expected Result:

Amount field should be grayed out because it is changed from the rate offline.

Actual Result:

Amount field is not grayed out when changing distance rate offline.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• [x]MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6563316_1722946380136.bandicam_2024-08-06_20-08-53-476.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01199ead94cf3782d9
• Upwork Job ID: 1820883188663849553
• Last Price Increase: 2024-08-06
• Automatic offers:
• jjcoffee | Reviewer | 103451212
• etCoderDysto | Contributor | 103451215

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount field is not grayed out when changing distance rate offline

What is the root cause of that problem?

We are checking for amount change pending action only here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 503 in 290a9d9

<OfflineWithFeedback pendingAction={getPendingFieldAction('amount')}>

What changes do you think we should make in order to solve the problem?

We should also check for tax rate change pending action too

<OfflineWithFeedback pendingAction={getPendingFieldAction('amount') ?? getPendingFieldAction('customUnitRateID')}>

What alternative solutions did you explore? (Optional)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-08 07:31:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Amount field is not grayed out when changing distance rate offline

What is the root cause of that problem?

In getUpdateMoneyRequestParams the amount is recalculated if hasPendingWaypoints || hasModifiedDistanceRate is true but the pending action/error for amount is not added.

App/src/libs/actions/IOU.ts

Lines 2527 to 2553 in 963f8ce

	const hasPendingWaypoints = 'waypoints' in transactionChanges;
	const hasModifiedDistanceRate = 'customUnitRateID' in transactionChanges;
	if (transaction && updatedTransaction && (hasPendingWaypoints || hasModifiedDistanceRate)) {
	updatedTransaction = {
	...updatedTransaction,
	...TransactionUtils.calculateAmountForUpdatedWaypointOrRate(transaction, transactionChanges, policy, ReportUtils.isExpenseReport(iouReport)),
	};
	// Delete the draft transaction when editing waypoints when the server responds successfully and there are no errors
	successData.push({
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`,
	value: null,
	});
	// Revert the transaction's amount to the original value on failure.
	// The IOU Report will be fully reverted in the failureData further below.
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: {
	amount: transaction.amount,
	modifiedAmount: transaction.modifiedAmount,
	modifiedMerchant: transaction.modifiedMerchant,
	},
	});
	}

App/src/libs/actions/IOU.ts

Lines 2498 to 2500 in 963f8ce

	const pendingFields = Object.fromEntries(Object.keys(transactionChanges).map((key) => [key, CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE]));
	const clearedPendingFields = Object.fromEntries(Object.keys(transactionChanges).map((key) => [key, null]));
	const errorFields = Object.fromEntries(Object.keys(pendingFields).map((key) => [key, {[DateUtils.getMicroseconds()]: Localize.translateLocal('iou.error.genericEditFailureMessage')}]));

What changes do you think we should make in order to solve the problem?

Define pendingFields, clearedPendingFields & errorFields using let instead of const and when we update the amount update all these.

    if (transaction && updatedTransaction && (hasPendingWaypoints || hasModifiedDistanceRate)) {
        updatedTransaction = {
            ...updatedTransaction,
            ...TransactionUtils.calculateAmountForUpdatedWaypointOrRate(transaction, transactionChanges, policy, ReportUtils.isExpenseReport(iouReport)),
        };

        pendingFields = {...pendingFields, amount: 'update'};
        clearedPendingFields = {...clearedPendingFields, amount: null};
        errorFields = {...errorFields, amount: {[DateUtils.getMicroseconds()]: Localize.translateLocal('iou.error.genericEditFailureMessage')}};

• The same should be done in getUpdateTrackExpenseParams also.

Note: We only need to update the pending action for amount. modifiedAmount, modifiedMerchant, and modifiedCurrency are only used to show the update messages.

App/src/pages/home/report/ReportActionItem.tsx

Lines 636 to 637 in 53eee53

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.MODIFIED_EXPENSE) {
	children = <ReportActionItemBasicMessage message={ModifiedExpenseMessage.getForReportAction(report.reportID, action)} />;

App/src/libs/ModifiedExpenseMessage.ts

Lines 115 to 138 in 53eee53

	function getForReportAction(reportID: string | undefined, reportAction: OnyxEntry<ReportAction>): string {
	if (!ReportActionsUtils.isModifiedExpenseAction(reportAction)) {
	return '';
	}
	const reportActionOriginalMessage = ReportActionsUtils.getOriginalMessage(reportAction);
	const policyID = ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.policyID ?? '-1';
	const removalFragments: string[] = [];
	const setFragments: string[] = [];
	const changeFragments: string[] = [];
	const hasModifiedAmount =
	reportActionOriginalMessage &&
	'oldAmount' in reportActionOriginalMessage &&
	'oldCurrency' in reportActionOriginalMessage &&
	'amount' in reportActionOriginalMessage &&
	'currency' in reportActionOriginalMessage;
	const hasModifiedMerchant = reportActionOriginalMessage && 'oldMerchant' in reportActionOriginalMessage && 'merchant' in reportActionOriginalMessage;
	if (hasModifiedAmount) {
	const oldCurrency = reportActionOriginalMessage?.oldCurrency;
	const oldAmountValue = reportActionOriginalMessage?.oldAmount ?? 0;
	const oldAmount = oldAmountValue > 0 ? CurrencyUtils.convertToDisplayString(reportActionOriginalMessage?.oldAmount ?? 0, oldCurrency) : '';

What alternative solutions did you explore? (Optional)