[HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Go offline
4. Submit a distance expense
5. Go to transaction thread
6. Click Distance
7. Change the waypoints (by exchanging position)
8. Save it

Expected Result:

App will not crash

Actual Result:

App crashes when submitting distance expense and editing distance offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563090_1722927597481.20240806_145640.mp4

logs (2).txt

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[BrtqKr]

convertToDisplayString() seems to be receiving 'Pending...' as a currency, which probably happens after editing the expense offline. I can dig deeper into it if that's ok.

That's probably unrelated to this particular bug, but I'm also getting double workspaces after creating a new one 🤔

[grgia]

#46165
#40021

could be related. It does seem like ^ is the issue

[grgia]

@BrtqKr maybe https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L255-L257

[paultsimura]

Ohh, this is a regression from my PR. Will spin up a fix now.