[HOLD for payment 2024-09-09] [$250] Workflows - Delay submissions option is not grayed when clicking offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Click on account setting
3. Click Workspace and create a new one
4. Click More features and click workflows
5. Go offline and navigate on the workflows page
6. Turn off or on the add approvals and payments option and observe that they are grayed
7. Turn off or on the delayed submission option and observe that it is not grayed

Expected Result:

Delay submissions option and submission frequency options must be greyed when clicking offline

Actual Result:

Delay submissions option and submission frequency options are not greyed when clicking offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554710_1722088625609.2024-07-27_16_46_08.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01573ccab630d178e7
• Upwork Job ID: 1820455952702489901
• Last Price Increase: 2024-08-05
• Automatic offers:
• abzokhattab | Contributor | 103452790

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

@abzokhattab Your proposal will be dismissed because you did not follow the proposal template.

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-08-03 22:20:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Delay submissions" option is not grayed out when clicking offline.

What is the root cause of that problem?

When toggling the delayed submissions on and off, the autoReportingFrequency is added to the pendingFields here . However, when displaying the field, we check for autoReporting instead of autoReportingFrequency.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 155 in 17dbd84

pendingAction: policy?.pendingFields?.autoReporting,

What changes do you think we should make in order to solve the problem?

We should update the autoReporting in the WorkspaceWorkflowsPage to autoReportingFrequency. This way, it matches the one set in the setWorkspaceAutoReportingFrequency function.

optionally: currently when toggling the enable workspace on and off we add the autoReporting into the pending fields ... so instead of changing it here to autoReportingFrequency we can add the autoReportingFrequency as the fallback value : policy?.pendingFields?.autoReporting ?? policy?.pendingFields?.autoReportingFrequency

Also we have the same problem in the errorFields its set as autoReportingFrequency in the failure data but we check for the autoReporting, so we need to change this to autoReportingFrequency as well (or using it as fallback value)

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 124 in 17dbd84

const hasDelayedSubmissionError = !!policy?.errorFields?.autoReporting;

What alternative solutions did you explore? (Optional)

We can remove autoReporting from everywhere in the App and keep only the autoReportingFrequency where when the value is disabled we should use CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT as we are doing here

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delay submissions option and submission frequency options are not greyed when clicking offline

What is the root cause of that problem?

There're 2 problems:

1. When toggle the delay submission option, we just update the autoReportingFrequency pendingField

App/src/libs/actions/Policy/Policy.ts

Line 383 in b8539ab

pendingFields: {autoReportingFrequency: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE},

but we're using autoReporting in

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 155 in b8539ab

pendingAction: policy?.pendingFields?.autoReporting,

so we can't see the greyed option

2. Even using autoReportingFrequency, we still face with this issue when users toggle workflow in More features since we just set autoReporting pendingField when enabled is false. So in case users enable workflow offline, it doesn't show the greyed option

App/src/libs/actions/Policy/Policy.ts

Line 2810 in b8539ab

autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

What changes do you think we should make in order to solve the problem?

We should use policy?.pendingFields?.autoReporting ?? policy?.pendingFields?.autoReportingFrequency ?? policy?.pendingFields?.areWorkflowsEnabled in here

or policy?.pendingFields?.autoReportingFrequency ?? policy?.pendingFields?.areWorkflowsEnabled for simpler

What alternative solutions did you explore? (Optional)

NA

We can consider to update autoReportingFrequency optimistically in enablePolicyWorkflows, then we just need to use policy?.pendingFields?.autoReportingFrequency

[abzokhattab]

Proposal updated

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01573ccab630d178e7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)