[$250] Categorizing - Date picker on confirmation page does not show the selected date

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4807531
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM
3. Track a manual expense
4. Go to transaction thread
5. Click Date and change to another date
6. Return to main chat
7. Click Categorize it > Select any category
8. Click Date on confirmation page
9. Change to a different date and save it
10. Click Date again

Expected Result:

The date picker will display the latest selected date in Step 9

Actual Result:

The date picker displays the selected date in Step 5, which is the date edited after tracking the expense and before categorizing
When saving the date without changing it, the latest date in Step 9 remains selected instead of the date shown in Step 10

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6560402_1722620558526.20240803_013609.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013cac8c72a835b3bf
• Upwork Job ID: 1820982675228792931
• Last Price Increase: 2024-08-07
• Automatic offers:
• eh2077 | Reviewer | 103427314
• abzokhattab | Contributor | 103427316

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[hayes102]

I can not reproduce the issue

[melvin-bot]

📣 @hayes102! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-08-03 16:48:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The date picker on the confirmation page does not display the last selected date.

What is the root cause of that problem?

1. When a request's date is updated, the modifiedCreated value is set to a specific date.

2. Later, when the date is changed on the confirmation page during expense categorization, the created property of the transaction is modified.

3. When retrieving the created date here , if modifiedCreated is present, the code returns the modifiedCreated date instead of the created date.

What changes do you think we should make in order to solve the problem?

When creating the draft transaction while categorizing the request, we should set modifiedCreated to undefined, similar to how we clear the modifiedMerchant:

App/src/libs/ReportUtils.ts

Lines 7206 to 7218 in 6a22933

	IOU.createDraftTransaction({
	...transaction,
	actionableWhisperReportActionID: reportActionID,
	linkedTrackedExpenseReportAction,
	linkedTrackedExpenseReportID: reportID,
	created,
	amount,
	currency,
	comment,
	merchant,
	modifiedMerchant: '',
	mccGroup,
	} as Transaction);

Alternatively

We should update the logic so that when setting the created date, it also checks and updates the modifiedCreated property if it exists.

function setMoneyRequestCreated(transactionID: string, created: string, isDraft: boolean, modifiedCreated?: string) {
    Onyx.merge(
        `${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
        modifiedCreated
            ? {
                  modifiedCreated: created,
                  created
              }
            : {created},
    );
}

Finally, modify the setMoneyRequestCreated call here .

OR

we can just set the modifiedCreated as undefined:

function setMoneyRequestCreated(transactionID: string, created: string, isDraft: boolean) {
    Onyx.merge(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {
        created,
        modifiedCreated: null,
    });
}

POC

Screen.Recording.2024-08-03.at.6.45.05.PM.mov

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013cac8c72a835b3bf