[HOLD for payment 2024-10-29][$125] [Search v1.2] - Admin can delete employee's expenses in Search page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Admin and employee are in the same workspace

1. Go to staging.new.expensify.com
2. [Employee] Submit an expense in the workspace chat
3. [Admin] Go to Search
4. [Admin] Select the expense submitted by employee via checkbox
5. [Admin] Click on the dropdown

Expected Result:

Delete option should not be available for admin in Search because Delete option is not present for admin in the transaction thread

Actual Result:

Delete option is available for admin in Search when Delete option is not present for admin in the transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6560363_1722618441824.20240803_005930.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f10851e4c993906
• Upwork Job ID: 1821118379211606096
• Last Price Increase: 2024-10-29

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-control

[lanitochka17]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

📣 @MuaazArshad! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[github-actions]

Expensifybot Your proposal will be dismissed because you did not follow the proposal template.

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete option is available for admin in Search when Delete option is not present for admin in the transaction thread

What is the root cause of that problem?

Here is the condition to display delete option in report detail page:

App/src/pages/ReportDetailsPage.tsx

Line 197 in b8539ab

const canDeleteRequest = isActionOwner && (ReportUtils.canDeleteTransaction(moneyRequestReport) || isSelfDMTrackExpenseReport) && !isDeletedParentAction;

and here is the condition to display delete option in search page:

App/src/components/Search/SearchPageHeader.tsx

Line 211 in 459759d

const shouldShowDeleteOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canDelete);

in there, canDelete is returned by BE and its value is true

What changes do you think we should make in order to solve the problem?

Should make sure, if user is admin, use is able to delete expense by updating

App/src/pages/ReportDetailsPage.tsx

Line 197 in b8539ab

const canDeleteRequest = isActionOwner && (ReportUtils.canDeleteTransaction(moneyRequestReport) || isSelfDMTrackExpenseReport) && !isDeletedParentAction;

to

    const isAdmin = policy?.role === CONST.POLICY.ROLE.ADMIN;
    const canDeleteRequest = (isActionOwner || isAdmin) && (ReportUtils.canDeleteTransaction(moneyRequestReport) || isSelfDMTrackExpenseReport) && !isDeletedParentAction;

[dylanexpensify]

reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f10851e4c993906